From: Steven Rostedt <rostedt@goodmis.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
liubo <liubo2009@cn.fujitsu.com>,
Linux Btrfs <linux-btrfs@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH 1/2] tracing: add __print_symbolic_u64 to avoid warnings on 32bit machine
Date: Wed, 25 May 2011 21:17:07 -0400 [thread overview]
Message-ID: <1306372627.1465.131.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4DDDA7F5.9020001@cn.fujitsu.com>
On Thu, 2011-05-26 at 09:08 +0800, Li Zefan wrote:
> Steven Rostedt wrote:
> Actually it's more than a compile warning fix.
>
> After a variable is cast from u64 to u32 and passed to __print_symbolic(),
> we'll see incorrect result in the trace output.
Don't worry, I didn't even say a warning fix was not reason to get into
this merge window.
There was only two patches in my last pull request that were not fixing
a bug and/or warning, but adding enhancements. I rebased without them
and even added this patch and another bug fix patch to get ready to push
out.
After my ktest runs are done (I test each patch on x86_64 and x86_32,
and then compile test them on a bunch of other archs), I'll do another
git pull request for this merge window.
Thanks!
-- Steve
next prev parent reply other threads:[~2011-05-26 1:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 6:42 [RFC PATCH] Trace: use unsigned long long in trace print frames liubo
2011-04-01 13:49 ` Steven Rostedt
2011-04-02 1:41 ` liubo
2011-04-06 9:18 ` [PATCH] Trace: add __print_symbolic_u64 to avoid warnings on 32bit machine liubo
2011-04-15 16:24 ` Randy Dunlap
2011-04-15 16:37 ` Christoph Hellwig
2011-04-18 18:11 ` Steven Rostedt
2011-04-19 1:08 ` liubo
2011-04-19 1:35 ` [PATCH 1/2] tracing: " liubo
2011-04-29 10:01 ` liubo
2011-05-01 15:35 ` Steven Rostedt
2011-05-26 5:49 ` liubo
2011-05-25 12:27 ` Steven Rostedt
2011-05-25 16:12 ` Randy Dunlap
2011-05-25 16:47 ` Steven Rostedt
2011-05-25 16:50 ` Randy Dunlap
2011-05-26 1:08 ` Li Zefan
2011-05-26 1:17 ` Steven Rostedt [this message]
2011-05-27 12:48 ` [tip:perf/urgent] tracing: Add " tip-bot for liubo
2011-04-19 1:35 ` [PATCH 2/2] tracing: update btrfs's tracepoints to use u64 interface liubo
2011-05-27 12:48 ` [tip:perf/urgent] tracing: Update " tip-bot for liubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306372627.1465.131.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
--cc=lizf@cn.fujitsu.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®