From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3EDFC433E0 for ; Mon, 1 Jun 2020 12:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9ABAF20679 for ; Mon, 1 Jun 2020 12:35:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aTpTPKCG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726125AbgFAMfL (ORCPT ); Mon, 1 Jun 2020 08:35:11 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:39520 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725935AbgFAMfK (ORCPT ); Mon, 1 Jun 2020 08:35:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591014909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wBls6dso9hCO4rI4kYDinlWW4RbCZK4JGwW4cnToAWE=; b=aTpTPKCGVxWzE9dxR3V88Q1AUuxgwtp/R2vg0bzFEPr8cNTm7dY9RuxcKTNOQnb/TjpvGp jM+pcqk5LFLDHKFUNmn3CO4UvMEaTuDkMXLYtKxAU42OfH0ouO9ppjd+dcSfhcUlln+CJI vWbmHBUTML5jqUDEyn1GJqz+qmmy/BM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-9eo9lp6gNlu9Yo_iflGRGg-1; Mon, 01 Jun 2020 08:35:07 -0400 X-MC-Unique: 9eo9lp6gNlu9Yo_iflGRGg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1E338005AA; Mon, 1 Jun 2020 12:35:05 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-138.rdu2.redhat.com [10.10.112.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 819432DE93; Mon, 1 Jun 2020 12:35:02 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Markus Elfring Cc: dhowells@redhat.com, Zhihao Cheng , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Yi Zhang Subject: Re: [PATCH] afs: Fix memory leak in afs_put_sysnames() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 01 Jun 2020 13:35:01 +0100 Message-ID: <1306563.1591014901@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Markus Elfring wrote: > > sysnames should be freed after refcnt being decreased to zero in > > afs_put_sysnames(). >=20 > * I suggest to use the wording =E2=80=9Creference counter=E2=80=9D. Can you use ASCII quotes please? Not all fonts contain these quotes, and occasionally they got copied into commit messages. > * Where did you notice a =E2=80=9Cmemory leak=E2=80=9D here? He said "sysnames should be freed after refcnt being decreased to zero in afs_put_sysnames()". > * Will the tag =E2=80=9CFixes=E2=80=9D become relevant for the commit mes= sage? It is the correct tag. David