From: Andi Kleen <andi@firstfloor.org>
To: viro@zeniv.linux.org.uk
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
tytso@mit.edu
Subject: [PATCH 2/4] EXT4: Set NOSEC flag early when there are no xattrs v2
Date: Sat, 28 May 2011 08:25:52 -0700 [thread overview]
Message-ID: <1306596354-18453-2-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1306596354-18453-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
This avoids a xattr lookup on every write.
v2: Use helper
Cc: tytso@mit.edu
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
fs/ext4/ialloc.c | 4 ++++
fs/ext4/inode.c | 6 ++++++
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 21bb2f6..e0aabdb 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -1012,6 +1012,10 @@ got:
*/
ei->i_flags =
ext4_mask_flags(mode, EXT4_I(dir)->i_flags & EXT4_FL_INHERITED);
+ /*
+ * New inode doesn't have security xattrs.
+ */
+ inode_has_no_xattr(inode);
ei->i_file_acl = 0;
ei->i_dtime = 0;
ei->i_block_group = group;
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index f2fa5e8..1079d02 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4758,6 +4758,12 @@ void ext4_set_inode_flags(struct inode *inode)
inode->i_flags |= S_NOATIME;
if (flags & EXT4_DIRSYNC_FL)
inode->i_flags |= S_DIRSYNC;
+ /*
+ * Don't know yet if an xattr is really security related, but the first
+ * write will find out.
+ */
+ if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR))
+ inode_has_no_xattr(inode);
}
/* Propagate flags from i_flags to EXT4_I(inode)->i_flags */
--
1.7.4.4
next prev parent reply other threads:[~2011-05-28 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 15:25 [PATCH 1/4] Cache xattr security drop check for write v2 Andi Kleen
2011-05-28 15:25 ` Andi Kleen [this message]
2011-05-28 15:25 ` [PATCH 3/4] BTRFS: Set NOSEC early for btrfs v2 Andi Kleen
2011-05-28 15:25 ` [PATCH 4/4] XFS: Set NOSEC flag early when inode has no xattrs. v2 Andi Kleen
2011-05-31 13:51 ` [PATCH 1/4] Cache xattr security drop check for write v2 Steven Whitehouse
2011-05-31 18:06 ` Andi Kleen
2011-05-31 18:42 ` Steven Whitehouse
2011-05-31 20:07 ` Al Viro
2011-05-31 20:18 ` Andi Kleen
2011-05-31 20:21 ` Al Viro
2011-06-18 6:58 ` Marco Stornelli
2011-06-18 18:04 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306596354-18453-2-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome