From: David Woodhouse <dwmw2@infradead.org>
To: Alex Williamson <alex.williamson@redhat.com>,
Weidong Han <weidong.han@intel.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
Vinod Koul <vinod.koul@intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
iommu@lists.linux-foundation.org,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] pci, dmar: Update dmar units devices list during hotplug
Date: Sat, 28 May 2011 23:11:35 +0100 [thread overview]
Message-ID: <1306620697.2029.329.camel@i7.infradead.org> (raw)
In-Reply-To: <1306327429.3100.122.camel@x201>
On Wed, 2011-05-25 at 06:43 -0600, Alex Williamson wrote:
>
> Ugh, that's going to make it pretty difficult to use a dynamic lookup
> approach. Maybe we're stuck with caching the scope->pdev translation
> somewhere.
Can't you handle it on BUS_NOTIFY_ADD_DEVICE notification, and store it
in pdev->dev.archdata? Might as well do the ATSR the same way, so it
matches.
Hm, why the hell do we have device_to_iommu(), which seems to duplicate
the dmar_find_matched_drhd_unit() function? Introduced by Weidong in
commit c7151a8d in 2008... Weidong?
I have a *vague* recollection that we cannot assume that there will be a
matching extant pci_dev for every call to device_to_iommu(), which is
why it takes domai^H^H^H^H^Hsegment/bus/devfn arguments as it does. And
that would be a reasonable excuse for adding it in the first place, I
suppose. I note your patch will break if that's true...
--
dwmw2
prev parent reply other threads:[~2011-05-28 22:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 18:48 Yinghai Lu
2011-05-19 22:15 ` Alex Williamson
2011-05-24 10:58 ` David Woodhouse
2011-05-24 17:42 ` Alex Williamson
2011-05-24 18:11 ` Yinghai Lu
2011-05-24 19:34 ` Yinghai Lu
2011-05-24 20:07 ` Alex Williamson
2011-05-24 20:24 ` Yinghai Lu
2011-05-24 20:34 ` Alex Williamson
2011-05-24 21:45 ` Yinghai Lu
2011-05-24 22:38 ` Alex Williamson
2011-05-24 23:02 ` Yinghai Lu
2011-05-25 5:42 ` Yinghai Lu
2011-05-25 5:45 ` Yinghai Lu
2011-05-25 12:43 ` Alex Williamson
2011-05-28 22:11 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306620697.2029.329.camel@i7.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=weidong.han@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®