From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755932Ab1E3Nwd (ORCPT ); Mon, 30 May 2011 09:52:33 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:32934 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755505Ab1E3Nwa (ORCPT ); Mon, 30 May 2011 09:52:30 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=UNqw8jQZZujcdw2F/s6EkR29jouAss2l96JCa8Skhx2GdiNGA3XCouj8iWHeDJntdH u+TCBgGw5zrOkILfEw/AxFlRaQpr0j1OY4HSMBjS2ClEHKcdv4iDjMaP9CHnLHSLNfMZ MrlT42IjlhBGkek3B89+QcKzluOVPUGR875MQ= From: Akinobu Mita To: linux-kernel@vger.kernel.org Cc: Akinobu Mita , reiserfs-devel@vger.kernel.org Subject: [PATCH 2/3] reiserfs: use proper little-endian bitops Date: Mon, 30 May 2011 22:53:14 +0900 Message-Id: <1306763595-13908-2-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1306763595-13908-1-git-send-email-akinobu.mita@gmail.com> References: <1306763595-13908-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using __test_and_{set,clear}_bit_le() with ignoring its return value can be replaced with __{set,clear}_bit_le(). Signed-off-by: Akinobu Mita Cc: reiserfs-devel@vger.kernel.org --- fs/reiserfs/bitmap.c | 3 +-- fs/reiserfs/resize.c | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/reiserfs/bitmap.c b/fs/reiserfs/bitmap.c index f70dd69..f9e26c1 100644 --- a/fs/reiserfs/bitmap.c +++ b/fs/reiserfs/bitmap.c @@ -212,8 +212,7 @@ static int scan_bitmap_block(struct reiserfs_transaction_handle *th, } /* otherwise we clear all bit were set ... */ while (--i >= *beg) - __test_and_clear_bit_le - (i, bh->b_data); + __clear_bit_le(i, bh->b_data); reiserfs_restore_prepared_buffer(s, bh); *beg = org; /* ... and search again in current block from beginning */ diff --git a/fs/reiserfs/resize.c b/fs/reiserfs/resize.c index 1e6f4c2..cd17ae2 100644 --- a/fs/reiserfs/resize.c +++ b/fs/reiserfs/resize.c @@ -136,7 +136,7 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new) return -EIO; } memset(bh->b_data, 0, sb_blocksize(sb)); - __test_and_set_bit_le(0, bh->b_data); + __set_bit_le(0, bh->b_data); reiserfs_cache_bitmap_metadata(s, bh, bitmap + i); set_buffer_uptodate(bh); @@ -172,7 +172,7 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new) reiserfs_prepare_for_journal(s, bh, 1); for (i = block_r; i < s->s_blocksize * 8; i++) - __test_and_clear_bit_le(i, bh->b_data); + __clear_bit_le(i, bh->b_data); info->free_count += s->s_blocksize * 8 - block_r; journal_mark_dirty(&th, s, bh); @@ -190,7 +190,7 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new) reiserfs_prepare_for_journal(s, bh, 1); for (i = block_r_new; i < s->s_blocksize * 8; i++) - __test_and_set_bit_le(i, bh->b_data); + __set_bit_le(i, bh->b_data); journal_mark_dirty(&th, s, bh); brelse(bh); -- 1.7.4.4