mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jon Masters <jcm@redhat.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Kyle McMartin <kmcmartin@redhat.com>
Subject: Re: [PATCH] depmod: Handle X.Y kernel versions
Date: Mon, 30 May 2011 20:46:14 -0400	[thread overview]
Message-ID: <1306802774.4987.18.camel@constitution.bos.jonmasters.org> (raw)
In-Reply-To: <4DE3AF93.40405@suse.cz>

On Mon, 2011-05-30 at 16:54 +0200, Michal Marek wrote:
> On 30.5.2011 16:43, Kay Sievers wrote:
> > On Mon, May 30, 2011 at 15:58, Michal Marek<mmarek@suse.cz>  wrote:
> >> What a stupid check.
> >
> > Maybe get rid of the entire check?

> Why not. It tries to distinguish between
> depmod da.da.da (kernel version)
> and
> depmod /path/to/module.ko ... (only generate tables for listed modules)
> 
> Either we can check for slashes in the second use case, or just drop 
> support for it.

Well, for tonight I'm just killing off the 3 number check and taking the
patch from Michal that matches on two numbers (thanks Kyle for sending
another version earlier in the day too but we don't need to be quite so
cleaver, just distinguish between a version and module path passed in).
I'll post a separate email announcing a new release with this fix.

I know it's a silly check, but it's probably not the only silly check
out there in the wild world yonder. Part of me thinks it'd be better to
just keep it as 3.0.0 so that we don't have an ongoing series of script
explosions. Another part of me is just so excited to finally see a 3.0
release that I've forgotten about 2.6 entirely (that's /so/ last week).

Jon.



  reply	other threads:[~2011-05-31  0:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30 13:58 Michal Marek
2011-05-30 14:43 ` Kay Sievers
2011-05-30 14:54   ` Michal Marek
2011-05-31  0:46     ` Jon Masters [this message]
2011-05-31  6:02       ` Jon Masters
2011-05-30 18:05 ` david
2011-05-31  9:07 ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306802774.4987.18.camel@constitution.bos.jonmasters.org \
    --to=jcm@redhat.com \
    --cc=kay.sievers@vrfy.org \
    --cc=kmcmartin@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®