mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: "John Stultz" <john.stultz@linaro.org>,
	"Arve Hj�nnev�g" <arve@android.com>,
	"Thomas Gleixner" <tglx@linutronix.de>
Subject: [RFC][PATCH 0/2] Avoid accumulating drift in suspend/resume
Date: Tue, 31 May 2011 23:07:47 -0700	[thread overview]
Message-ID: <1306908469-15275-1-git-send-email-john.stultz@linaro.org> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1110 bytes --]

Arve Hjønnevåg noted that in the suspend/resume path, we're likely to see
half-second errors from each read of the RTC. If a system is frequently
suspended, these errors will accumulate quickly.

Arve's solution was to compare the time delta between the system time
and the RTC, for each suspend. If the difference is small, use the same
delta for each suspend. This consistency avoids the error from accumulating.

This patch set implements Arve's suggestion for both the RTC and persistent
clock suspend paths.

Initial tests show that this improves time accuracy over many repeated
suspends. So while testing continues, I just wanted to send this out for
review and feedback.

thanks
-john

CC: Arve Hjønnevåg <arve@android.com>
CC: Thomas Gleixner <tglx@linutronix.de>

John Stultz (2):
  time: Avoid accumulating time drift in suspend/resume
  rtc: Avoid accumulating time drift in suspend/resume

 drivers/rtc/class.c       |   65 +++++++++++++++++++++++++++++++++------------
 kernel/time/timekeeping.c |   22 +++++++++++++++
 2 files changed, 70 insertions(+), 17 deletions(-)

-- 
1.7.3.2.146.gca209


             reply	other threads:[~2011-06-01  6:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01  6:07 John Stultz [this message]
2011-06-01  6:07 ` [PATCH 1/2] time: Avoid accumulating time " John Stultz
2011-06-01  6:07 ` [PATCH 2/2] rtc: " John Stultz
2011-06-02  0:54   ` Arve Hjønnevåg
2011-06-02  1:14     ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306908469-15275-1-git-send-email-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=arve@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome