From: Igor Mammedov <imammedo@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: imammedo@redhat.com, kamezawa.hiroyu@jp.fujitsu.com,
balbir@linux.vnet.ibm.com, akpm@linux-foundation.org
Subject: [PATCH] memcg: do not expose uninitialized mem_cgroup_per_node to world
Date: Wed, 1 Jun 2011 12:44:04 +0200 [thread overview]
Message-ID: <1306925044-2828-1-git-send-email-imammedo@redhat.com> (raw)
Freshly allocated 'mem_cgroup_per_node' list entries must be
initialized before the rest of the kernel can see them. Otherwise
zero initialized list fields can lead to race condition at
mem_cgroup_force_empty_list:
pc = list_entry(list->prev, struct page_cgroup, lru);
where 'pc' will be something like 0xfffffffc if list->prev is 0
and cause page fault later when 'pc' is dereferenced.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
mm/memcontrol.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index bd9052a..ee7cb4c 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4707,7 +4707,6 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node)
if (!pn)
return 1;
- mem->info.nodeinfo[node] = pn;
for (zone = 0; zone < MAX_NR_ZONES; zone++) {
mz = &pn->zoneinfo[zone];
for_each_lru(l)
@@ -4716,6 +4715,7 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node)
mz->on_tree = false;
mz->mem = mem;
}
+ mem->info.nodeinfo[node] = pn;
return 0;
}
--
1.7.1
next reply other threads:[~2011-06-01 10:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 10:44 Igor Mammedov [this message]
2011-06-01 12:39 ` Michal Hocko
2011-06-01 13:07 ` Igor Mammedov
2011-06-01 13:41 ` Michal Hocko
2011-06-01 14:39 ` Igor Mammedov
2011-06-01 15:20 ` Michal Hocko
2011-06-01 16:42 ` Igor Mammedov
2011-06-01 23:10 ` Hiroyuki Kamezawa
2011-06-03 12:35 ` Igor Mammedov
2011-06-03 13:00 ` Hiroyuki Kamezawa
2011-06-07 13:25 ` Igor Mammedov
2011-06-08 3:35 ` KAMEZAWA Hiroyuki
2011-06-08 21:09 ` Andrew Morton
2011-06-08 23:44 ` KAMEZAWA Hiroyuki
2011-06-10 16:57 ` Igor Mammedov
2011-07-26 21:17 ` Andrew Morton
2011-07-27 7:58 ` Michal Hocko
2011-07-27 9:30 ` Igor Mammedov
2011-07-27 9:57 ` Michal Hocko
2011-06-09 8:11 ` Igor Mammedov
2011-06-09 12:40 ` Possible shadow bug (was: Re: [PATCH] memcg: do not expose uninitialized mem_cgroup_per_node to world) Stefano Stabellini
2011-06-09 15:01 ` [Xen-devel] " Tim Deegan
2011-06-09 16:47 ` [Xen-devel] Possible shadow bug Igor Mammedov
2011-06-10 10:01 ` Tim Deegan
2011-06-10 10:10 ` Tim Deegan
2011-06-10 11:48 ` Pasi Kärkkäinen
2011-06-10 12:40 ` Tim Deegan
2011-06-10 15:38 ` Igor Mammedov
2011-06-10 13:55 ` Igor Mammedov
2011-06-01 13:49 ` [PATCH] memcg: do not expose uninitialized mem_cgroup_per_node to world Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306925044-2828-1-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome