From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mike Galbraith <efault@gmx.de>,
Yong Zhang <yong.zhang0@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sched: fix conflict of schedule domain balance in RT scheduling
Date: Fri, 03 Jun 2011 10:52:04 -0400 [thread overview]
Message-ID: <1307112724.3667.58.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <BANLkTim-tr+LAg1pA-wEFvVGiCvOYdfDoQ@mail.gmail.com>
On Fri, 2011-06-03 at 22:30 +0800, Hillf Danton wrote:
> I note the comment related to cache-hot, it is fine for woken task even though
> cache-hot is considered to be nop for RT task,
I would not say cache-hot is a nop for RT tasks. Although RT tasks
should not depend on cache being hot, we don't want to go out of our way
to hurt RT tasks.
> but what dose it help pushing
> RT tasks waiting on RQ?
What the lowest_mask returns is a mask of all cpus with the lowest
priority. Due to the double_lock_balance() we could have unlocked the rq
lock, and things could have changed. Thus, the current CPU could have
lowered its priority. Unlikely to be the case, but can happen.
If the lowest_mask has the task's CPU set, why push this RT task
somewhere else? Most likely the current CPU will not be set, but lets
not punish the RT task if it is.
-- Steve
next prev parent reply other threads:[~2011-06-03 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 13:58 Hillf Danton
2011-06-02 11:56 ` Peter Zijlstra
2011-06-03 14:38 ` Hillf Danton
2011-06-03 14:19 ` Steven Rostedt
2011-06-03 14:30 ` Hillf Danton
2011-06-03 14:52 ` Steven Rostedt [this message]
2011-06-03 15:21 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307112724.3667.58.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®