mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>
Subject: [PATCH 0/5] Demystified CFQ Oops
Date: Sun, 05 Jun 2011 18:26:18 +0200	[thread overview]
Message-ID: <1307291187.8545.41.camel@t41.thuisdomein> (raw)

This is a set of five commits that should demystify a CFQ Oops that I
was able to easily trigger on a laptop I use. (It is actually still
unclear why it was exactly so easy for me to trigger it on that laptop.)

This set contains one trivial fix, three clean-ups and one commit that
should actually fix this issue. The clean-ups were essential in helping
pinpoint the problem and should make review a lot easier.

Review of the last patch - which covers stuff rather unfamiliar to me -
would be especially appreciated.

I must admit that, while finalizing this set, I have not tested that the
set is cleanly bisectable (ie, that all commits lead to a tree that at
least builds). I could still do that, but perhaps there's someone with
more experience and especially with (much) more powerful hardware for
whom that would be much easier to do than for me.

Paul Bolle (5):
  CFQ: make two functions static
  Rename two struct members called "cic_list"
  CFQ: rename ioc_data to last_cic
  block: rename the return of two functions
  CFQ: use proper locking for cache of last hit cic

 block/blk-ioc.c           |   50 ++++++++++++++++++++++----------------------
 block/cfq-iosched.c       |   49 +++++++++++++++++++++++++++-----------------
 include/linux/iocontext.h |    6 ++--
 3 files changed, 58 insertions(+), 47 deletions(-)

-- 
1.7.5.2




                 reply	other threads:[~2011-06-05 16:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307291187.8545.41.camel@t41.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®