From: Paul Bolle <pebolle@tiscali.nl>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Vivek Goyal <vgoyal@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] CFQ: rename ioc_data to last_cic
Date: Mon, 06 Jun 2011 21:13:11 +0200 [thread overview]
Message-ID: <1307387596.1841.24.camel@t41.thuisdomein> (raw)
In-Reply-To: <4DEC4342.1070101@kernel.dk>
On Mon, 2011-06-06 at 05:02 +0200, Jens Axboe wrote:
> It's really io scheduler agnostic, but cfq is the only user. Lets leave
> the flexibility there.
So that agnosticism and flexibility is unused right now. This might
again have to do with my perspective, but understanding that
ioc->ioc_data
(which really is rather opaque) basically meant (something like)
ioc->cic_last
was a bit of an eye opener for me. But you have to maintain this code,
which makes this your decision, obviously.
Paul Bolle
prev parent reply other threads:[~2011-06-06 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 16:26 Paul Bolle
2011-06-06 3:02 ` Jens Axboe
2011-06-06 19:13 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307387596.1841.24.camel@t41.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®