Re: two false alarms from checkpatch.pl

[Joe Perches <joe@perches.com>]

On Mon, 2011-06-13 at 16:18 -0700, Jian Peng wrote:
> After running "./scripts/checkpatch.pl -F arch/mips/kernel/syscall.c", I got some errors reported on valid lines
> 
> ERROR: space prohibited before open square bracket '['
> #451: FILE: mips/kernel/syscall.c:451:
> +		: [addr] "r" (addr),
> 
> This line is valid, and if I remove the space in between, it will report a different error
> 
> ERROR: spaces required around that ':' (ctx:ExV)
> #448: FILE: mips/kernel/syscall.c:448:
> +		:[old] "=&r" (old),
>  		^
> In another case, it reported

Known defect.  checkpatch doesn't correctly parse asm.
checkpatch output isn't dicta.
You should just ignore it.

> ERROR: trailing statements should be on next line
> #515: FILE: mips/kernel/syscall.c:515:
> +	while (1);
> 
> This is also valid line.

That's really not a kernel style conformant line.

It really should be written as something like:

	while (1) {
		;		/* Never exit */
	}