From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org, rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH]mm: use correct address for pte_unmap_unlock in zap_pte_range
Date: Wed, 15 Jun 2011 12:43:30 +0200 [thread overview]
Message-ID: <1308134610.15315.35.camel@twins> (raw)
In-Reply-To: <20110615102909.GA23759@sli10-conroe.sh.intel.com>
On Wed, 2011-06-15 at 18:29 +0800, Shaohua Li wrote:
> Boot an i386 kernel, I got:
> [ 3.766613] WARNING: at /workshop/kernel/git/my/linux/arch/x86/mm/highmem_32.c:81 __kunmap_atomic+0x6f/0x113()
> [ 3.766615] Hardware name: Studio XPS 8000
> [ 3.766617] Modules linked in:
> [ 3.766619] Pid: 214, comm: blkid Not tainted 3.0.0-rc3+ #529
> [ 3.766621] Call Trace:
> [ 3.766625] [<c1063803>] warn_slowpath_common+0x6a/0x7f
> [ 3.766628] [<c104f494>] ? __kunmap_atomic+0x6f/0x113
> [ 3.766631] [<c106382c>] warn_slowpath_null+0x14/0x18
> [ 3.766633] [<c104f494>] __kunmap_atomic+0x6f/0x113
> [ 3.766637] [<c10e6033>] zap_pte_range+0x291/0x2b4
> [ 3.766641] [<c105a37d>] ? get_parent_ip+0xb/0x31
> [ 3.766644] [<c10e6180>] unmap_page_range+0x12a/0x147
> [ 3.766647] [<c10e6243>] unmap_vmas+0xa6/0xe2
> [ 3.766650] [<c10e7c26>] exit_mmap+0x78/0xd3
> [ 3.766654] [<c106207a>] mmput+0x39/0x99
> [ 3.766657] [<c106582f>] exit_mm+0x101/0x109
> [ 3.766660] [<c1066d83>] do_exit+0x1e6/0x312
> [ 3.766664] [<c10fff66>] ? fput+0x18/0x1a
> [ 3.766666] [<c1066f16>] do_group_exit+0x67/0x8a
> [ 3.766669] [<c1066f51>] sys_exit_group+0x18/0x1c
> [ 3.766673] [<c1620154>] syscall_call+0x7/0xb
>
> the zap_pte_range does:
> pte = pte_offset_map_lock(mm, pmd, addr, &ptl);
> do {
> ...
> if (force_flush)
> break;
> ...
> } while (pte++, addr += PAGE_SIZE, addr != end);
>
> pte_unmap_unlock(pte - 1, ptl);
>
> the pte_unmap_unlock(pte - 1) only works if pte++ does once.
>
> this is a regression introduced by d16dfc550f5326a4000f3(mm: mmu_gather
> rework)
Already send by Steven and picked up by Andrew:
lkml.kernel.org/r/1307158665.3667.86.camel@gandalf.stny.rr.com
lkml.kernel.org/r/201106040413.p544D9ox027032@imap1.linux-foundation.org
Apparently it hasn't made its way to Linus though.
next prev parent reply other threads:[~2011-06-15 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 10:29 Shaohua Li
2011-06-15 10:43 ` Peter Zijlstra [this message]
2011-06-16 5:04 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308134610.15315.35.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shaohua.li@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®