From: Greg Dietsche <Gregory.Dietsche@cuw.edu>
To: gregkh@suse.de
Cc: brudley@broadcom.com, henryp@broadcom.com, dowan@broadcom.com,
rvossen@broadcom.com, arend@broadcom.com,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Greg Dietsche <Gregory.Dietsche@cuw.edu>
Subject: [PATCH] staging: brcm80211: return false if not a broadcom board
Date: Wed, 15 Jun 2011 17:25:09 -0500 [thread overview]
Message-ID: <1308176709-14765-1-git-send-email-Gregory.Dietsche@cuw.edu> (raw)
This code looks wrong to me. I think it meant to return false
if the board's vendor id isn't Broadcom's.
Compile tested only.
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
---
drivers/staging/brcm80211/brcmsmac/wlc_bmac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c b/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c
index 4534926..ee13238 100644
--- a/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c
+++ b/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c
@@ -1943,7 +1943,7 @@ static bool wlc_validboardtype(struct wlc_hw_info *wlc_hw)
}
if (wlc_hw->sih->boardvendor != PCI_VENDOR_ID_BROADCOM)
- return goodboard;
+ goodboard = false;
return goodboard;
}
--
1.7.2.5
next reply other threads:[~2011-06-15 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 22:25 Greg Dietsche [this message]
2011-06-16 1:36 ` Henry Ptasinski
2011-06-16 2:49 ` Greg Dietsche
2011-06-16 23:37 ` Henry Ptasinski
2011-06-16 23:45 ` Julian Calaby
2011-06-17 22:01 ` Henry Ptasinski
2011-06-18 15:52 ` Greg Dietsche
2011-06-16 5:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308176709-14765-1-git-send-email-Gregory.Dietsche@cuw.edu \
--to=gregory.dietsche@cuw.edu \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=dowan@broadcom.com \
--cc=gregkh@suse.de \
--cc=henryp@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®