mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Mike Galbraith <efault@gmx.de>,
	Yong Zhang <yong.zhang0@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sched: find all lowest run-queues for RT task
Date: Thu, 16 Jun 2011 12:57:25 -0400	[thread overview]
Message-ID: <1308243445.9218.145.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1308243122.9218.143.camel@gandalf.stny.rr.com>

On Thu, 2011-06-16 at 12:52 -0400, Steven Rostedt wrote:

> > diff --git a/kernel/sched_cpupri.c b/kernel/sched_cpupri.c
> > index 2722dc1..d4c0b46 100644
> > --- a/kernel/sched_cpupri.c
> > +++ b/kernel/sched_cpupri.c
> > @@ -181,8 +181,10 @@ int cpupri_init(struct cpupri *cp)
> >  			goto cleanup;
> >  	}
> > 
> > -	for_each_possible_cpu(i)
> > +	for_each_possible_cpu(i) {
> >  		cp->cpu_to_pri[i] = CPUPRI_INVALID;
> > +		cpupri_set(cp, i, MAX_RT_PRIO);
> > +	}
> 
> This is OK, and I may add it. It's just an initialization, and because
> things like the migration thread run on all CPUs, the first time an RT
> task is run on a CPU and dequeued, it will have the cpupri_set() to
> MX_RT_PRIO anyway. But for clean up sake, it may be good to initialize
> it to a valid mask and not be ZERO.
> 

I take it back, this isn't needed either, as the cpupri_set() is
initialized when the rq comes on line.

-- Steve



      reply	other threads:[~2011-06-16 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-03 14:11 Hillf Danton
2011-06-16 16:52 ` Steven Rostedt
2011-06-16 16:57   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308243445.9218.145.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=dhillf@gmail.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®