mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sidharth Saha <ssaha2000@gmail.com>
To: Matheus Alves de Almeida <matheus.aalmeida@inf.ufrgs.br>,
	Louis Chauvet <louis.chauvet@bootlin.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	Melissa Wen <melissa.srw@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] drm/vkms: support more formats and fix RGB565 regression
Date: Sat, 7 Nov 2026 20:08:02 -0700	[thread overview]
Message-ID: <13083638-9316-4d5b-8590-f104de3def3a@gmail.com> (raw)
In-Reply-To: <20260928005301.367977-1-matheus.aalmeida@inf.ufrgs.br>

Hi Matheus,

I tested this series on top of drm-misc-next (7.3.0-rc4) with vkms in
a VirtualBox VM, running IGT with and without the series applied.

kms_writeback: writeback-pixel-formats, writeback-invalid-parameters,
writeback-fb-id and writeback-check-output pass both with and without
the series (writeback-check-output passed 4/4 runs on each), so I see
no regression in the existing writeback path.

kms_plane: pixel-format-linear-modifier fails both with and without
the series, on the assertion in capture_crc() (crc->frame != vblank),
before it reaches the new formats. This looks like the existing
kms_plane CRC issue listed in the vkms TODO rather than anything in
this series.

I wasn't able to exercise the RGB332/BGR233 read paths or BGR565
writeback with these tests, so no Tested-by for the series as a whole.
I did test the RGB565 rounding fix with a KUnit test, and I'll reply
to patch 1/5 with the details.

Thanks,
Sidharth

On 9/27/2026 5:52 PM, Matheus Alves de Almeida wrote:
> Hi,
> 
> This series adds support for RGB332, BGR233 and BGR565 writeback. This
> is done with new helpers added to make conversion easier. It also fixes
> a regression in the RGB565 write conversion. 


      parent reply	other threads:[~2026-11-08  3:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  0:52 Matheus Alves de Almeida
2026-09-28  0:52 ` [PATCH 1/5] drm/vkms: make argb_u16_to_RGB565 round resulting values Matheus Alves de Almeida
2026-11-08  3:12   ` Sidharth Saha
2026-09-28  0:52 ` [PATCH 2/5] drm/vkms: support BGR565 writeback Matheus Alves de Almeida
2026-09-28  0:52 ` [PATCH 3/5] drm/vkms: add a helper for channel to argb_u16 conversion Matheus Alves de Almeida
2026-09-28  0:53 ` [PATCH 4/5] drm/vkms: add support for RGB332 Matheus Alves de Almeida
2026-09-28  0:53 ` [PATCH 5/5] drm/vkms: add support for BGR233 Matheus Alves de Almeida
2026-10-12 19:18 ` [PATCH 0/5] drm/vkms: support more formats and fix RGB565 regression Matheus Alves de Almeida
2026-11-08  3:08 ` Sidharth Saha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13083638-9316-4d5b-8590-f104de3def3a@gmail.com \
    --to=ssaha2000@gmail.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matheus.aalmeida@inf.ufrgs.br \
    --cc=melissa.srw@gmail.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®