From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Avi Kivity <avi@redhat.com>
Cc: Zachary Amsden <zamsden@redhat.com>, kvm <kvm@vger.kernel.org>,
Linux-kernel <linux-kernel@vger.kernel.org>,
Ulrich Obergfell <uobergfe@redhat.com>
Subject: Re: [PATCH x86 kvm] Fix register corruption in pvclock_scale_delta
Date: Wed, 22 Jun 2011 10:52:01 +0100 [thread overview]
Message-ID: <1308736321.6920.174.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <4E01B89C.7050704@redhat.com>
On Wed, 2011-06-22 at 10:40 +0100, Avi Kivity wrote:
> On 06/22/2011 12:35 PM, Ian Campbell wrote:
> > On Sun, 2011-06-19 at 15:44 +0300, Avi Kivity wrote:
> > > On 06/16/2011 06:50 AM, Zachary Amsden wrote:
> > > > The 128-bit multiply in pvclock.h was missing an output constraint for
> > > > EDX which caused a register corruption to appear.
> >
> > Was there any particular symptom associated with corruption at that
> > particular point or just general badness?
> >
>
> Time went backwards and forwards as vcpus were migrated across cpus.
Oops!
> The problem was in the host, not the guest, so Xen should not be affected.
Good to know, thanks!
Ian.
next prev parent reply other threads:[~2011-06-22 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 3:50 Zachary Amsden
2011-06-19 12:44 ` Avi Kivity
2011-06-22 9:35 ` Ian Campbell
2011-06-22 9:39 ` Avi Kivity
2011-06-22 9:40 ` Avi Kivity
2011-06-22 9:52 ` Ian Campbell [this message]
2011-08-30 8:58 Duncan Sands
2011-08-30 11:39 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308736321.6920.174.camel@zakaz.uk.xensource.com \
--to=ian.campbell@eu.citrix.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uobergfe@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®