From: <stefano.stabellini@eu.citrix.com>
To: hpa@zytor.com
Cc: hpa@linux.intel.com, konrad.wilk@oracle.com, mingo@elte.hu,
linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
Stefano.Stabellini@eu.citrix.com, yinghai@kernel.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH] x86_64: do not assume head_64.S used 4KB pages when !use_pse
Date: Thu, 23 Jun 2011 12:14:25 +0100 [thread overview]
Message-ID: <1308827665-28890-1-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
head_64.S, which sets up the initial page table on x86_64, is not aware
of PSE being enabled or disabled and it always allocates the initial
mapping using 2MB pages.
Therefore on x86_64 find_early_table_space shouldn't update the amount
of pages needed for pte pages depending on the size of the initial
mapping, because we know for sure that no pte pages have been allocated
yet.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Reported-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/init.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index 36bacfe..1e3098b 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -42,12 +42,19 @@ static void __init find_early_table_space(unsigned long start,
(PMD_SIZE * PTRS_PER_PMD));
pmd_mapped *= (PMD_SIZE * PTRS_PER_PMD);
+ /*
+ * On x86_64 do not limit the size we need to cover with 4KB pages
+ * depending on the initial allocation because head_64.S always uses
+ * 2MB pages.
+ */
+#ifdef CONFIG_X86_32
if (start < PFN_PHYS(max_pfn_mapped)) {
if (PFN_PHYS(max_pfn_mapped) < end)
size -= PFN_PHYS(max_pfn_mapped) - start;
else
size = 0;
}
+#endif
#ifndef __PAGETABLE_PUD_FOLDED
if (end > pud_mapped) {
--
1.7.2.3
next reply other threads:[~2011-06-23 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 11:14 stefano.stabellini [this message]
2011-06-23 23:46 ` [tip:x86/mm] x86-64, mm: Do " tip-bot for Stefano Stabellini
2011-06-23 12:38 [PATCH] x86_64: do " Penttilä Mika
2011-06-23 12:56 ` Stefano Stabellini
2011-06-23 14:50 ` Penttilä Mika
2011-06-23 15:19 ` Stefano Stabellini
2011-06-23 16:25 ` Penttilä Mika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308827665-28890-1-git-send-email-stefano.stabellini@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xen-devel@lists.xensource.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®