From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Gregory Haskins <ghaskins@novell.com>
Subject: Re: [RFC] sched: update rto_mask for RT runqueue
Date: Thu, 23 Jun 2011 13:55:06 -0400 [thread overview]
Message-ID: <1308851706.531.35.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <BANLkTin8EF5ZpWmXKGwbZqTf5+GZBBFhfQ@mail.gmail.com>
On Thu, 2011-06-23 at 21:43 +0800, Hillf Danton wrote:
> Hi Steven
>
> Since {de, en}queue_pushable_task() is not always accompanied with
> {dec, inc}_rt_migration(), when the last pushable RT task on RQ is picked in
> pick_next_task_rt(), we have to update rto_mask for the RQ in question, which
> helps puller that is guided by rto_mask.
Hmm, I don't care much for this patch, but you did bring up something
that is interesting. That there may be a disconnect between the rto_mask
and the pushable tasks. A pushable task is the same as a pullable task.
So I'm thinking about revamping this to merge the two and make the code
simpler.
This may take a lot of testing to make sure that we did not create any
regressions.
-- Steve
prev parent reply other threads:[~2011-06-23 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 13:43 Hillf Danton
2011-06-23 17:55 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308851706.531.35.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dhillf@gmail.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®