mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric B Munson <emunson@mgebm.net>
To: mingo@elte.hu
Cc: a.p.zijlstra@chello.nl, borislav.petkov@amd.com,
	bblum@andrew.cmu.edu, linux-kernel@vger.kernel.org,
	mhack@us.ibm.com, eranian@google.com,
	Eric B Munson <emunson@mgebm.net>
Subject: [PATCH 3/3] events: Ensure that timers are updated without requiring read() call
Date: Thu, 23 Jun 2011 16:34:39 -0400	[thread overview]
Message-ID: <1308861279-15216-3-git-send-email-emunson@mgebm.net> (raw)
In-Reply-To: <1308861279-15216-1-git-send-email-emunson@mgebm.net>

The event tracing infrastructure exposes two timers which should be updated
each time the value of the counter is updated.  Currently, these counters are
only updated when userspace calls read() on the fd associated with an event.
This means that counters which are read via the mmap'd page exclusively never
have their timers updated.  This patch adds ensures that the timers are updated
each time the values in the mmap'd page are updated.

Signed-off-by: Eric B Munson <emunson@mgebm.net>
---
 kernel/events/core.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 9e9a7fa..e3be175 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -3382,6 +3382,18 @@ void perf_event_update_userpage(struct perf_event *event)
 	struct perf_buffer *buffer;
 
 	rcu_read_lock();
+	/*
+	 * compute total_time_enabled, total_time_running
+	 * based on snapshot values taken when the event
+	 * was last scheduled in.
+	 *
+	 * we cannot simply called update_context_time()
+	 * because of locking issue as we are called in
+	 * NMI context
+	 */
+	calc_timer_values(event,
+				&event->total_time_enabled,
+				&event->total_time_running);
 	buffer = rcu_dereference(event->buffer);
 	if (!buffer)
 		goto unlock;
-- 
1.7.4.1


  parent reply	other threads:[~2011-06-23 20:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-23 20:34 [PATCH 1/3] events: Add note to update_event_times comment about holding ctx->lock Eric B Munson
2011-06-23 20:34 ` [PATCH 2/3] events: Move lockless timer calculation into helper function Eric B Munson
2011-07-01 15:20   ` [tip:perf/core] " tip-bot for Eric B Munson
2011-06-23 20:34 ` Eric B Munson [this message]
2011-06-24  9:44   ` [PATCH 3/3] events: Ensure that timers are updated without requiring read() call Peter Zijlstra
2011-06-24  9:46     ` Peter Zijlstra
2011-06-24 12:44     ` Eric B Munson
2011-06-24 12:49     ` Eric B Munson
2011-06-27  9:34       ` Peter Zijlstra
2011-07-01 15:19 ` [tip:perf/core] events: Add note to update_event_times comment about holding ctx->lock tip-bot for Eric B Munson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308861279-15216-3-git-send-email-emunson@mgebm.net \
    --to=emunson@mgebm.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=bblum@andrew.cmu.edu \
    --cc=borislav.petkov@amd.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhack@us.ibm.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®