From: John Kacur <jkacur@redhat.com>
To: "James E.J. Bottomley" <JBottomley@parallels.com>,
lkml <linux-kernel@vger.kernel.org>
Cc: Eric Moore <eric.moore@lsi.com>,
linux-scsi@vger.kernel.org, John Kacur <jkacur@redhat.com>
Subject: [PATCH] [SCSI] mpt2sas: Remove duplicate code in mpt2sas_base_attach
Date: Fri, 24 Jun 2011 11:59:29 +0200 [thread overview]
Message-ID: <1308909569-5293-1-git-send-email-jkacur@redhat.com> (raw)
Remove this duplicate code I found by inspection.
Signed-off-by: John Kacur <jkacur@redhat.com>
---
drivers/scsi/mpt2sas/mpt2sas_base.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index efa0255..2660b3c 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -3933,13 +3933,6 @@ mpt2sas_base_attach(struct MPT2SAS_ADAPTER *ioc)
goto out_free_resources;
}
- if (!ioc->base_cmds.reply || !ioc->transport_cmds.reply ||
- !ioc->scsih_cmds.reply || !ioc->tm_cmds.reply ||
- !ioc->config_cmds.reply || !ioc->ctl_cmds.reply) {
- r = -ENOMEM;
- goto out_free_resources;
- }
-
init_completion(&ioc->shost_recovery_done);
for (i = 0; i < MPI2_EVENT_NOTIFY_EVENTMASK_WORDS; i++)
--
1.7.2.3
reply other threads:[~2011-06-24 9:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308909569-5293-1-git-send-email-jkacur@redhat.com \
--to=jkacur@redhat.com \
--cc=JBottomley@parallels.com \
--cc=eric.moore@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®