From: Jin Park <jinyoungp@nvidia.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Richard Purdie <rpurdie@rpsys.net>, Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org, Jin Park <jinyoungp@nvidia.com>
Subject: Re: [PATCH 0/3] aat2870: Adding mfd, backlight and regulator drivers
Date: Wed, 29 Jun 2011 23:06:49 +0900 [thread overview]
Message-ID: <1309356412-23881-1-git-send-email-jinyoungp@nvidia.com> (raw)
Changing subject because the patch was separated.
Adding relevant maintainers for backlight and regulator.
Hi Samuel,
> Before reviewing this patch, could you please do the following:
>
> 1) Split it into 3 actual patches: the MFD one, the regulator one and the
> backlight one.
I have separated the patch to mfd, backlight and regulator.
> 2) Add the relevant maintainers (See MAINTAINERS) if you want to get a proper
> regulator and backlight driver review.
I submitting the patches with relevant maintainers.
> You also need to take the io_lock mutex here, to prevent someone else to write
> a different value to your register between your read and write.
> So what you typically want is an unlocked version of aat2870_[read|write]
> (let's say we call it __aat2870_[read|write]). Then your aat2870_[read|write]
> become wrappers around the __aat2870_[read|write] with the lock taken. And
> your update_bits routine can use __aat2870_[read|write] with the lock taken
> from the beginning.
I have modified mfd driver according to your comment.
Thanks,
Jin.
Jin Park (3):
mfd: aat2870: Add AAT2870 mfd driver
backlight: aat2870: Add AAT2870 backlight driver
regulator: aat2870: Add AAT2870 regulator driver
drivers/mfd/Kconfig | 10 +
drivers/mfd/Makefile | 1 +
drivers/mfd/aat2870-core.c | 534 +++++++++++++++++++++++++++++++++
drivers/regulator/Kconfig | 7 +
drivers/regulator/Makefile | 1 +
drivers/regulator/aat2870-regulator.c | 264 ++++++++++++++++
drivers/video/backlight/Kconfig | 7 +
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/aat2870_bl.c | 246 +++++++++++++++
include/linux/mfd/aat2870.h | 181 +++++++++++
10 files changed, 1252 insertions(+), 0 deletions(-)
create mode 100644 drivers/mfd/aat2870-core.c
create mode 100644 drivers/regulator/aat2870-regulator.c
create mode 100644 drivers/video/backlight/aat2870_bl.c
create mode 100644 include/linux/mfd/aat2870.h
next reply other threads:[~2011-06-29 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 14:06 Jin Park [this message]
2011-06-29 14:06 ` [PATCH 1/3] mfd: aat2870: Add AAT2870 mfd driver Jin Park
2011-07-04 15:54 ` Samuel Ortiz
2011-06-29 14:06 ` [PATCH 2/3] backlight: aat2870: Add AAT2870 backlight driver Jin Park
2011-06-29 14:06 ` [PATCH 3/3] regulator: aat2870: Add AAT2870 regulator driver Jin Park
2011-07-01 16:39 ` Mark Brown
2011-07-01 16:34 ` [PATCH 0/3] aat2870: Adding mfd, backlight and regulator drivers Mark Brown
2011-07-04 17:59 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309356412-23881-1-git-send-email-jinyoungp@nvidia.com \
--to=jinyoungp@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®