From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932100Ab1F2U1a (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Jun 2011 16:27:30 -0400
Received: from he.sipsolutions.net ([78.46.109.217]:44069 "EHLO
	sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757650Ab1F2U12 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Jun 2011 16:27:28 -0400
Subject: Re: [PATCH] net, wireless: Don't return uninitialized in
 __cfg80211_stop_sched_scan()
From: Johannes Berg <johannes@sipsolutions.net>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        "John W. Linville" <linville@tuxdriver.com>,
        Luciano Coelho <coelho@ti.com>
In-Reply-To: <alpine.LNX.2.00.1106292212110.3747@swampdragon.chaosbits.net>
References: <alpine.LNX.2.00.1106292212110.3747@swampdragon.chaosbits.net>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 29 Jun 2011 22:27:24 +0200
Message-ID: <1309379244.4071.7.camel@jlt3.sipsolutions.net>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.3 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2011-06-29 at 22:13 +0200, Jesper Juhl wrote:
> If the 'driver_initiated' function argument to
> __cfg80211_stop_sched_scan() is not 0 then we'll return an
> uninitialized 'ret' from the function.

'err'. I also dislike the initialisation, can we just replace the
"return err;" at the end of the function with "return 0;" instead?

Luca, should it maybe be return -ENOENT anyway in the !sched_scan_req
case?

johannes