From: Steven Rostedt <rostedt@goodmis.org>
To: Dima Zavin <dima@android.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] plist: add mutex to the blessed lock type for plists
Date: Wed, 29 Jun 2011 16:43:41 -0400 [thread overview]
Message-ID: <1309380221.26417.50.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <CAPz4a6CbzEm3QJZ-5wsaiSH1H9g7tgo7E7-HyRB8Fv5=NfGDRQ@mail.gmail.com>
On Wed, 2011-06-29 at 13:34 -0700, Dima Zavin wrote:
> The whole enforcement of locking inside this code is awkward anyway.
> We don't enforce locking on rb_trees, or on list_head, etc. Why
> plists? The funny part is that the test code in plist.c itself has a
> hack to skip the lock check.
It's a legacy from the -rt tree. With the development there, there was
always a case where a plist was added without the proper locking, and we
spent days debugging it. This test proved very useful. As plists came to
mainline, we kept the tests.
Now, getting rid of them maybe the thing to do. I'm not sure how useful
they are today.
-- Steve
next prev parent reply other threads:[~2011-06-29 20:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 19:33 Dima Zavin
2011-06-29 20:01 ` Steven Rostedt
2011-06-29 20:10 ` Dima Zavin
2011-06-29 20:12 ` Dima Zavin
2011-06-29 20:13 ` Andi Kleen
2011-06-29 20:34 ` Dima Zavin
2011-06-29 20:43 ` Steven Rostedt [this message]
2011-06-30 22:14 ` Dima Zavin
2011-06-30 22:45 ` Steven Rostedt
2011-07-02 10:09 ` Peter Zijlstra
2011-06-29 20:36 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309380221.26417.50.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=andi@firstfloor.org \
--cc=dima@android.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®