From: Julia Lawall <julia@diku.dk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: kernel-janitors@vger.kernel.org,
Joakim Tjernlund <joakim.tjernlund@transmode.se>,
Tadashi Abe <tabe@mvista.com>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Stefani Seibold <stefani@seibold.net>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/mtd/lpddr/lpddr_cmds.c: eliminate double free
Date: Mon, 4 Jul 2011 16:20:17 +0200 [thread overview]
Message-ID: <1309789217-22947-1-git-send-email-julia@diku.dk> (raw)
From: Julia Lawall <julia@diku.dk>
The only call to lpddr_cmdset is in the function defined in lpddr_probe
drivers/mtd/lpddr/qinfo_probe.c. If the result of calling lpddr_cmdset is
NULL, this function frees lpddr. So lpddr should not be freed in
lpddr_cmdset.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/mtd/lpddr/lpddr_cmds.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c
index 65655dd..b7f265e 100644
--- a/drivers/mtd/lpddr/lpddr_cmds.c
+++ b/drivers/mtd/lpddr/lpddr_cmds.c
@@ -89,7 +89,6 @@ struct mtd_info *lpddr_cmdset(struct map_info *map)
shared = kmalloc(sizeof(struct flchip_shared) * lpddr->numchips,
GFP_KERNEL);
if (!shared) {
- kfree(lpddr);
kfree(mtd);
return NULL;
}
reply other threads:[~2011-07-04 14:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309789217-22947-1-git-send-email-julia@diku.dk \
--to=julia@diku.dk \
--cc=dwmw2@infradead.org \
--cc=joakim.tjernlund@transmode.se \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=stefani@seibold.net \
--cc=tabe@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®