From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541Ab1GETD7 (ORCPT ); Tue, 5 Jul 2011 15:03:59 -0400 Received: from mail-fx0-f52.google.com ([209.85.161.52]:43824 "EHLO mail-fx0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244Ab1GETDU (ORCPT ); Tue, 5 Jul 2011 15:03:20 -0400 From: Vitaly Kuzmichev To: linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, Russell King , Marc Zyngier , Wim Van Sebroeck Cc: arm@kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , John Stultz , Nicolas Pitre , Thomas Gleixner , Vitaly Kuzmichev Subject: [PATCH V2 3/6] mpcore_wdt: Fix WDIOC_SETOPTIONS handling Date: Tue, 5 Jul 2011 23:00:37 +0400 Message-Id: <1309892440-3260-4-git-send-email-vkuzmichev@mvista.com> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1286185540-19569-1-git-send-email-vkuzmichev@mvista.com> References: <1286185540-19569-1-git-send-email-vkuzmichev@mvista.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the include/linux/watchdog.h WDIOC_SETOPTIONS is classified as 'read from device' ioctl call: #define WDIOC_SETOPTIONS _IOR(WATCHDOG_IOCTL_BASE, 4, int) However, the driver 'mpcore_wdt' performs 'copy_from_user' only if _IOC_WRITE is set, thus the local variable 'uarg' which is used in WDIOC_SETOPTIONS handling remains uninitialized. The proper way to fix this is to bind WDIOC_SETOPTIONS to _IOW, but this will break compatibility. So adding additional condition for performing 'copy_from_user'. Signed-off-by: Vitaly Kuzmichev --- drivers/watchdog/mpcore_wdt.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/watchdog/mpcore_wdt.c b/drivers/watchdog/mpcore_wdt.c index 7a3d6b2..b330a0a 100644 --- a/drivers/watchdog/mpcore_wdt.c +++ b/drivers/watchdog/mpcore_wdt.c @@ -240,7 +240,8 @@ static long mpcore_wdt_ioctl(struct file *file, unsigned int cmd, if (_IOC_DIR(cmd) && _IOC_SIZE(cmd) > sizeof(uarg)) return -ENOTTY; - if (_IOC_DIR(cmd) & _IOC_WRITE) { + if (_IOC_DIR(cmd) & _IOC_WRITE + || cmd == WDIOC_SETOPTIONS) { ret = copy_from_user(&uarg, (void __user *)arg, _IOC_SIZE(cmd)); if (ret) return -EFAULT; -- 1.7.3.4