From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Liam Girdwood <lrg@ti.com>, Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Misael Lopez Cruz <misael.lopez@ti.com>,
Felipe Balbi <balbi@ti.com>
Subject: [PATCH v3 5/5] MFD: twl6040: Remove wrapper for threaded irq request
Date: Tue, 5 Jul 2011 22:49:36 +0300 [thread overview]
Message-ID: <1309895376-17446-6-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1309895376-17446-1-git-send-email-peter.ujfalusi@ti.com>
Remove the twl6040_request_irq/free_irq inline functions,
and use direct calls instead in the core driver to
register the threaded irq.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/mfd/twl6040-core.c | 10 +++++-----
include/linux/mfd/twl6040.h | 22 ----------------------
2 files changed, 5 insertions(+), 27 deletions(-)
diff --git a/drivers/mfd/twl6040-core.c b/drivers/mfd/twl6040-core.c
index f71bb14..6843977 100644
--- a/drivers/mfd/twl6040-core.c
+++ b/drivers/mfd/twl6040-core.c
@@ -502,9 +502,9 @@ static int __devinit twl6040_probe(struct platform_device *pdev)
if (ret)
goto gpio2_err;
- ret = twl6040_request_irq(twl6040, TWL6040_IRQ_READY,
- twl6040_naudint_handler, 0,
- "twl6040_irq_ready", twl6040);
+ ret = request_threaded_irq(twl6040->irq_base + TWL6040_IRQ_READY,
+ NULL, twl6040_naudint_handler, 0,
+ "twl6040_irq_ready", twl6040);
if (ret) {
dev_err(twl6040->dev, "READY IRQ request failed: %d\n",
ret);
@@ -557,7 +557,7 @@ static int __devinit twl6040_probe(struct platform_device *pdev)
return 0;
mfd_err:
- twl6040_free_irq(twl6040, TWL6040_IRQ_READY, twl6040);
+ free_irq(twl6040->irq_base + TWL6040_IRQ_READY, twl6040);
irq_err:
twl6040_irq_exit(twl6040);
gpio2_err:
@@ -580,7 +580,7 @@ static int __devexit twl6040_remove(struct platform_device *pdev)
if (gpio_is_valid(twl6040->audpwron))
gpio_free(twl6040->audpwron);
- twl6040_free_irq(twl6040, TWL6040_IRQ_READY, twl6040);
+ free_irq(twl6040->irq_base + TWL6040_IRQ_READY, twl6040);
twl6040_irq_exit(twl6040);
mfd_remove_devices(&pdev->dev);
diff --git a/include/linux/mfd/twl6040.h b/include/linux/mfd/twl6040.h
index c3c1de5..df890a2 100644
--- a/include/linux/mfd/twl6040.h
+++ b/include/linux/mfd/twl6040.h
@@ -215,28 +215,6 @@ struct twl6040 {
u8 irq_masks_cache;
};
-static inline int twl6040_request_irq(struct twl6040 *twl6040, int irq,
- irq_handler_t handler,
- unsigned long irqflags,
- const char *name,
- void *data)
-{
- if (!twl6040->irq_base)
- return -EINVAL;
-
- return request_threaded_irq(twl6040->irq_base + irq, NULL, handler,
- irqflags, name, data);
-}
-
-static inline void twl6040_free_irq(struct twl6040 *twl6040, int irq,
- void *data)
-{
- if (!twl6040->irq_base)
- return;
-
- free_irq(twl6040->irq_base + irq, data);
-}
-
int twl6040_reg_read(struct twl6040 *twl6040, unsigned int reg);
int twl6040_reg_write(struct twl6040 *twl6040, unsigned int reg,
u8 val);
--
1.7.6
next prev parent reply other threads:[~2011-07-05 19:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 19:49 [PATCH v3 0/5] MFD/input/ASoC: twl6040: irq registration changes Peter Ujfalusi
2011-07-05 19:49 ` [PATCH v3 1/5] MFD: twl6040: Use resource to provide irq number for slaves Peter Ujfalusi
2011-07-05 22:39 ` Felipe Balbi
2011-07-07 9:49 ` Samuel Ortiz
2011-07-05 19:49 ` [PATCH v3 2/5] input: twl6040-vibra: Do not use wrapper for irq request Peter Ujfalusi
2011-07-05 22:40 ` Felipe Balbi
2011-07-06 20:03 ` Dmitry Torokhov
2011-07-05 19:49 ` [PATCH v3 3/5] ASoC: twl6040: " Peter Ujfalusi
2011-07-05 22:41 ` Felipe Balbi
2011-07-05 19:49 ` [PATCH v3 4/5] MFD: twl6040: Demand valid interrupt configuration Peter Ujfalusi
2011-07-05 22:42 ` Felipe Balbi
2011-07-07 9:50 ` Samuel Ortiz
2011-07-05 19:49 ` Peter Ujfalusi [this message]
2011-07-05 22:42 ` [PATCH v3 5/5] MFD: twl6040: Remove wrapper for threaded irq request Felipe Balbi
2011-07-07 9:51 ` Samuel Ortiz
2011-07-06 19:45 ` [alsa-devel] [PATCH v3 0/5] MFD/input/ASoC: twl6040: irq registration changes Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309895376-17446-6-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®