mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Libin (Huawei)" <huawei.libin@huawei.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH v2] prctl: fix compat handling for prctl
Date: Thu, 19 Apr 2018 14:03:55 +0800	[thread overview]
Message-ID: <130bb5d0-e6a8-932b-3f56-ef021f10a8ba@huawei.com> (raw)
In-Reply-To: <CALCETrUmFfoWE55Nrkiq5cuvPw5oPFJKOg04ky-dJsDVsdSmbg@mail.gmail.com>



在 2018/4/19 10:25, Andy Lutomirski 写道:
>> On Apr 18, 2018, at 9:06 PM, Li Bin <huawei.libin@huawei.com> wrote:
>>
>> The member auxv in prctl_mm_map structure which be shared with
>> userspace is pointer type, but the kernel supporting COMPAT didn't
>> handle it. This patch fix the compat handling for prctl syscall.
> 
> I would propose an alternative fix: change the type to u64. As far as

But we also need to modify the sys/prctl.h in Glibc, right?

> I know, this thing is only used by CRIU, and CRIU doesn’t work (AFAIK)
> on native 32-bit anyway.   Do you know of some reason that this
> wouldn't work?
> 
> .
> 

  reply	other threads:[~2018-04-19  6:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  1:06 Li Bin
2018-04-19  1:35 ` Andy Lutomirski
2018-04-19  2:25 ` Andy Lutomirski
2018-04-19  6:03   ` Libin (Huawei) [this message]
2018-04-26 21:13   ` Dmitry Safonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=130bb5d0-e6a8-932b-3f56-ef021f10a8ba@huawei.com \
    --to=huawei.libin@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=guohanjun@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=luto@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®