From: Liu Ying <victor.liu@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, festevam@gmail.com,
krzysztof.kozlowski@linaro.org, saravanak@google.com,
geert+renesas@glider.be, robh+dt@kernel.org,
s.hauer@pengutronix.de, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v4 2/2] dt-bindings: bus: Add Freescale i.MX8qxp pixel link MSI bus binding
Date: Mon, 15 Aug 2022 10:55:58 +0800 [thread overview]
Message-ID: <130bc9c5d5da94b25e2ee456039b1818225f7bef.camel@nxp.com> (raw)
In-Reply-To: <1660502102.287520.546324.nullmailer@robh.at.kernel.org>
On Sun, 2022-08-14 at 12:35 -0600, Rob Herring wrote:
> On Sun, 14 Aug 2022 15:43:38 +0800, Liu Ying wrote:
> > Freescale i.MX8qxp pixel link MSI bus is a simple memory-mapped
> > bus.
> > It is used to access peripherals in i.MX8qm/qxp imaging, LVDS, MIPI
> > DSI and HDMI TX subsystems, like I2C controller, PWM controller,
> > MIPI DSI controller and Control and Status Registers (CSR) module.
> >
> > Reference simple-pm-bus bindings and add Freescale i.MX8qxp pixel
> > link MSI bus specific bindings.
> >
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > v3->v4:
> > * Add child nodes in the example MSI bus node of the MSI bus dt-
> > binding. (Krzysztof)
> >
> > v2->v3:
> > * Add a pattern property to allow child nodes. (Rob)
> >
> > v1->v2:
> > Address Krzysztof's comments:
> > * Add a select to explicitly select the MSI bus dt-binding.
> > * List 'simple-pm-bus' explicitly as one item of compatible
> > strings.
> > * Require compatible and reg properties.
> > * Put reg property just after compatible property in example.
> >
> > .../bus/fsl,imx8qxp-pixel-link-msi-bus.yaml | 232
> > ++++++++++++++++++
> > 1 file changed, 232 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-
> > bus.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-
> bus.example.dtb:0:0: /example-0/bus@56200000/syscon@56221000: failed
> to match any schema with compatible: ['fsl,imx8qxp-mipi-lvds-csr',
> 'syscon', 'simple-mfd']
> Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-
> bus.example.dtb:0:0: /example-0/bus@56200000/syscon@56221000/pxl2dpi:
> failed to match any schema with compatible: ['fsl,imx8qxp-pxl2dpi']
> Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-
> bus.example.dtb:0:0: /example-0/bus@56200000/syscon@56221000/ldb:
> failed to match any schema with compatible: ['fsl,imx8qxp-ldb']
I sent this a bit earlier than v6.0-rc1. Now, v6.0-rc1 is out and there
is no error if the base is v6.0-rc1.
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
> This check can fail if there are any dependencies. The base for a
> patch
> series is generally the most recent rc1.
Yes, there are dependencies if the base is v5.19-rc1.
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up
> to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
Do I need to re-submit? Or, you may run "make DT_CHECKER_FLAGS=-m
dt_binding_check" upon v6.0-rc1?
Regards,
Liu Ying
prev parent reply other threads:[~2022-08-15 2:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 7:43 [PATCH v4 0/2] drivers: bus: Add Freescale i.MX8qxp pixel link MSI bus support Liu Ying
2022-08-14 7:43 ` [PATCH v4 1/2] drivers: bus: simple-pm-bus: Use clocks Liu Ying
2022-08-14 7:43 ` [PATCH v4 2/2] dt-bindings: bus: Add Freescale i.MX8qxp pixel link MSI bus binding Liu Ying
2022-08-14 18:35 ` Rob Herring
2022-08-15 2:55 ` Liu Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130bc9c5d5da94b25e2ee456039b1818225f7bef.camel@nxp.com \
--to=victor.liu@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=saravanak@google.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®