From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C60FD70808 for ; Fri, 7 Aug 2026 01:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786064452; cv=none; b=ITvunVM75I9FPEFH0XzIpCY/x0kpdAJlHp6RUjAezBE7Jv3qonbqECkr1iOT6Boo8XWVLCQthg11NqdoZu7vkuS2y1UGE6rf1yJ5am+DpJ5ifJIMcS9EXOraU3qhwiHInaaL90Ai8s4NZJEeUe5/u/2uujH5eVo8IkjMc1sWU+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786064452; c=relaxed/simple; bh=iotslhaEZt8loWPGgkcIv0hGHfwfMOkEAmJhHNf8v2o=; h=Date:From:To:cc:Subject:Message-ID:MIME-Version:Content-Type; b=HbS4nFB/xILKTpEharAchY5rLJQEZeckbDTVk3/Cl6VRAWQLqu3WdkVj3jC3/4G58TjC03wZtJdSaOiKAWf+jxkFYrzTF3PJqynFUM3XrIyldxk1c3IE1mcFiQYP5JXUp8TqAk83h3TwuhLnrIXQ599yCUuS/lW9lfVF82jtuQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m1K+iYkD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m1K+iYkD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 143571F000E9; Fri, 7 Aug 2026 01:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786064451; bh=lKlp/e9fIvqOwqvKM8Ea6sHjy+W4jUSsKOtwkFyx2gk=; h=Date:From:To:cc:Subject; b=m1K+iYkDoPhDNl//S/Vhfkv8caQF0tELd3g/3xugcZUTWeHW9XCsTK8lVkz+H5HLP wRsETyR/cQovFqUJ3MqUbkC+jVNDkGSNDMLIuXXSdzUBbtPWTSFZwjwZDDA0AFgztH Bu6cJFQO/G6OxgvLjegPNOAp5Rp7Ga1u9mFHFRt96JWodrutmmHA+Drid6J4t61mrq fSNBcHyJXe11crzOm7RCpfMyFhLUewQpcedlQKKOPfCtHFwcIFvrD7gS+02JoZm6Qt qW1S7OwiqWkEiVRgGoMqvuB4Ml9geW3S5sq/oClwfRsPKEIPPsugidMRAUifwwmPeV 5StNqTVX9GAPw== Date: Thu, 6 Aug 2026 19:00:47 -0600 (MDT) From: Paul Walmsley To: apw@canonical.com, joe@perches.com, linux-kernel@vger.kernel.org cc: Nam Cao , Jisheng Zhang Subject: [PATCH] checkpatch: add NOKPROBE_SYMBOL to the whitelist of lines that can occur immediately after functions Message-ID: <130be7db-6098-86a4-60fe-0c1a5d9e30ba@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII It's customary for NOKPROBE_SYMBOL() macro usage to appear immedately after a function's final closing brace, but checkpatch doesn't know that yet. As a result, checkpatch --strict incorrectly flags this common kernel pattern, e.g., CHECK: Please use a blank line after function/struct/union/enum declarations 33: FILE: arch/riscv/kernel/traps.c:273: } +NOKPROBE_SYMBOL(probe_single_step_handler); Fix by adding NOKPROBE_SYMBOL to the whitelist of patterns that are cleared to appear immediately after functions. Cc: Nam Cao Cc: Jisheng Zhang Signed-off-by: Paul Walmsley --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2b7a42bbdd94..f8a57ed71f34 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4148,6 +4148,7 @@ sub process { $line =~ /^\+[a-z_]*init/ || $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || $line =~ /^\+\s*DECLARE/ || + $line =~ /^\+\s*NOKPROBE_SYMBOL/ || $line =~ /^\+\s*builtin_[\w_]*driver/ || $line =~ /^\+\s*__setup/)) { if (CHK("LINE_SPACING", -- 2.53.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE9D3426ED6 for ; Mon, 10 Aug 2026 16:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786381062; cv=none; b=F/4jiyb/x11Sqro3uzDvglsUoim/u7Q9Q70qkiX8CKZ3L9wiUk+g/+puarECxNKCfaeHXEX0LZkw3bBMGAI8M611/i2E74dzPvUazP+grjQL/+kcJEols0en7Exu8+Mfnn7XN+DF8Tn56FZ76E97UmvAcA5DS5/Y7cZVYtrQEUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786381062; c=relaxed/simple; bh=qhXvFSkfvN4i3ji5gETtJd7rc99sSlKEMzOo9OoFAac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HlGwbb9NZPS7hApZdPf/1f4C6mRI/OMR5pNBiIeJtv3hXYjloEDRt4FCVJck4PaAcGzCdEGdGAhbhSlAMKRZLzVT9S47udjVcDJfGT6kLO3slYXGPnEDosTe+JfDvQ4xiyrxtWMJB1TVpLtFY/yx9Z+/fte3KzEqRN2hBtObf6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=fMO0wFrp; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=hr5YjtvG; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=nF0ui82+; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=PCR+5MUB; dkim=neutral (0-bit key) header.d=kernel.org header.i=@kernel.org header.b=m1K+iYkD; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="fMO0wFrp"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="hr5YjtvG"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="nF0ui82+"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="PCR+5MUB"; dkim=neutral (0-bit key) header.d=kernel.org header.i=@kernel.org header.b="m1K+iYkD" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7012A80EC1; Mon, 10 Aug 2026 16:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1786381054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id: list-unsubscribe:list-subscribe; bh=JMv8Wzwbmc6PByR2pHI8KlDkt5iz7zEK6J7hj8rOTUQ=; b=fMO0wFrp++B+n5HzZ76+SIGe1KCwcC7lZFYqDIDrV1DOK++7bNcrcGRVIDC8auuj/Jorty YoDc4TvGE1+QitvG5oqt7GzkZzIBTyMYoE0bypEdb8LQ2mF6VmoNrmHjJ1yDtIMikOBVhg b26EOqhoJ3DrcinE3H0NGbmSgdFBo4Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1786381054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id: list-unsubscribe:list-subscribe; bh=JMv8Wzwbmc6PByR2pHI8KlDkt5iz7zEK6J7hj8rOTUQ=; b=hr5YjtvG+yfpkB7oE03AaqYICf42LMIn3VGTekvWcDi+FsJNtKeBZdxKe5NWy52DRqCCeN Q2vHbErw+qM0mWCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nF0ui82+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PCR+5MUB; dkim=fail ("body hash did not verify") header.d=kernel.org header.s=k20260515 header.b=m1K+iYkD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1786381050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id: list-unsubscribe:list-subscribe; bh=JMv8Wzwbmc6PByR2pHI8KlDkt5iz7zEK6J7hj8rOTUQ=; b=nF0ui82+eVONP7sc/SQvmLLx387ttqT0pWyaccb/2FGZlOywP6228F6n/MgHmFHM0mZqda iKKgeaO8pVg7kQKCfLzewIaeS3HlctuAcjVKX7HD25MhIENmQB7yMHczJE9dAkNUG+ZJG2 MffJsNeCrKqbU4Io9feQYMKFbUKp504= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1786381050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id: list-unsubscribe:list-subscribe; bh=JMv8Wzwbmc6PByR2pHI8KlDkt5iz7zEK6J7hj8rOTUQ=; b=PCR+5MUBqG4UqfuVasWx35TEWhSScvCqwcUKXba4xKtFP7/jXbcORzxsmpVaq6/iZ30RPP PnT31KAiLJ2tELBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3E4E9779B2; Mon, 10 Aug 2026 16:57:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LN88DvoCemqaYgAAD6G6ig (envelope-from ); Mon, 10 Aug 2026 16:57:30 +0000 From: Petr Vorel To: pjw@kernel.org, apw@canonical.com, joe@perches.com, linux-kernel@vger.kernel.org Cc: jszhang@kernel.org, namcao@linutronix.de, Andrew Morton , Petr Vorel Subject: [PATCH] checkpatch: add NOKPROBE_SYMBOL to the whitelist of lines that can occur immediately after functions Date: Mon, 10 Aug 2026 18:57:28 +0200 Message-ID: <130be7db-6098-86a4-60fe-0c1a5d9e30ba@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <130be7db-6098-86a4-60fe-0c1a5d9e30ba@kernel.org> References: <130be7db-6098-86a4-60fe-0c1a5d9e30ba@kernel.org> Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C60FD70808 for ; Fri, 7 Aug 2026 01:00:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 143571F000E9; Fri, 7 Aug 2026 01:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786064451; bh=lKlp/e9fIvqOwqvKM8Ea6sHjy+W4jUSsKOtwkFyx2gk=; h=Date:From:To:cc:Subject; b=m1K+iYkDoPhDNl//S/Vhfkv8caQF0tELd3g/3xugcZUTWeHW9XCsTK8lVkz+H5HLP wRsETyR/cQovFqUJ3MqUbkC+jVNDkGSNDMLIuXXSdzUBbtPWTSFZwjwZDDA0AFgztH Bu6cJFQO/G6OxgvLjegPNOAp5Rp7Ga1u9mFHFRt96JWodrutmmHA+Drid6J4t61mrq fSNBcHyJXe11crzOm7RCpfMyFhLUewQpcedlQKKOPfCtHFwcIFvrD7gS+02JoZm6Qt qW1S7OwiqWkEiVRgGoMqvuB4Ml9geW3S5sq/oClwfRsPKEIPPsugidMRAUifwwmPeV 5StNqTVX9GAPw== Precedence: bulk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-Spam-Score: -3.77 X-Spam-Level: X-Rspamd-Action: no action X-Rspamd-Queue-Id: 7012A80EC1 X-Spamd-Result: default: False [-3.77 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_RHS_MATCH_TO(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MAILLIST(-0.15)[generic]; SUSE_ML_WHITELIST_VGER(-0.10)[]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; R_DKIM_REJECT(0.00)[kernel.org:s=k20260515]; DKIM_MIXED(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+,kernel.org:-]; PREVIOUSLY_DELIVERED(0.00)[linux-kernel@vger.kernel.org]; FROM_EQ_ENVFROM(0.00)[]; PRECEDENCE_BULK(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received,100.103.45.18:received]; RCPT_COUNT_SEVEN(0.00)[8]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email,suse.cz:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,linutronix.de:email] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO Message-ID: <20260810165728.8_Jw_VWUPFMgn9Ah5yGr8upwcMLMa5zLc0Hv02uNCkw@z> From: Paul Walmsley > It's customary for NOKPROBE_SYMBOL() macro usage to appear immedately > after a function's final closing brace, but checkpatch doesn't know > that yet. As a result, checkpatch --strict incorrectly flags this > common kernel pattern, e.g., > CHECK: Please use a blank line after function/struct/union/enum declarations > 33: FILE: arch/riscv/kernel/traps.c:273: > } > +NOKPROBE_SYMBOL(probe_single_step_handler); > Fix by adding NOKPROBE_SYMBOL to the whitelist of patterns that are > cleared to appear immediately after functions. > Cc: Nam Cao > Cc: Jisheng Zhang > Signed-off-by: Paul Walmsley > --- > scripts/checkpatch.pl | 1 + > 1 file changed, 1 insertion(+) > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 2b7a42bbdd94..f8a57ed71f34 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -4148,6 +4148,7 @@ sub process { > $line =~ /^\+[a-z_]*init/ || > $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || > $line =~ /^\+\s*DECLARE/ || > + $line =~ /^\+\s*NOKPROBE_SYMBOL/ || > $line =~ /^\+\s*builtin_[\w_]*driver/ || > $line =~ /^\+\s*__setup/)) { > if (CHK("LINE_SPACING", +1 Reviewed-by: Petr Vorel Kind regards, Petr