From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751748AbdILSNB (ORCPT ); Tue, 12 Sep 2017 14:13:01 -0400 Received: from www381.your-server.de ([78.46.137.84]:49788 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbdILSM5 (ORCPT ); Tue, 12 Sep 2017 14:12:57 -0400 Subject: Re: [Outreachy kernel] [PATCH] Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string and added "" around names To: Daniel Baluta , Himanshi Jain Cc: outreachy-kernel , "Hennerich, Michael" , Jonathan Cameron , Hartmut Knaack , Peter Meerwald , Greg Kroah-Hartman , "linux-iio@vger.kernel.org" , driverdev , Linux Kernel Mailing List , nick.desaulniers@gmail.com References: <20170911224348.GA13259@himanshi-Inspiron-5558> From: Lars-Peter Clausen Message-ID: <130cbd01-265e-dafe-02d1-96de4d62ff12@metafoo.de> Date: Tue, 12 Sep 2017 20:12:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2017 09:53 AM, Daniel Baluta wrote: > Hi Himanshi, > > On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain wrote: >> Fixed IIO_DEVICE_ATTR_NAMED API to take name as a >> string instead of implicit conversion to string using >> preprocessors. Added double quotes around names in >> existing usage of IIO_DEVICE_ATTR_NAMED. > > Always use imperative mood in commit subject (Fix instead of Fixed). > > The subject should contain a tag, which describes the subsytem/files affected. > > I would split this patch into: > > 1) sysfs: iio: Introduce *_ATTR_NAMED > > and explain here why do we need __ATTR_NAMED and IIO_ATTR_NAMED > > 2) iio: Use new IIO_DEVICE_ATTR_NAMED API > > But of course, lets wait to see Lars and Jonathan's opinions. Fully agreed with what you wrote.