From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753964Ab1GJOgk (ORCPT ); Sun, 10 Jul 2011 10:36:40 -0400 Received: from mail.perches.com ([173.55.12.10]:3760 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752534Ab1GJOgj (ORCPT ); Sun, 10 Jul 2011 10:36:39 -0400 Subject: Re: [PATCH 5/5] dbri: Add missing breaks in switch/case From: Joe Perches To: linux-kernel@vger.kernel.org Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org In-Reply-To: <5aa8ee111dd52768622e89c06440e1328f0d2247.1310289795.git.joe@perches.com> References: <5aa8ee111dd52768622e89c06440e1328f0d2247.1310289795.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" Date: Sun, 10 Jul 2011 07:36:37 -0700 Message-ID: <1310308597.3848.21.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2011-07-10 at 02:28 -0700, Joe Perches wrote: defective patch, please ignore. > diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c > index 73f9cba..ca978b1 100644 > --- a/sound/sparc/dbri.c > +++ b/sound/sparc/dbri.c > @@ -578,14 +578,19 @@ static __u32 reverse_bytes(__u32 b, int len) > switch (len) { > case 32: > b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16); > + break; Maybe add a comment for fall through use instead.