From: Joe Perches <joe@perches.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 3/3] Staging: comedi: fix brace coding style issue in pcl818.c
Date: Sun, 10 Jul 2011 22:57:38 -0700 [thread overview]
Message-ID: <1310363858.2446.15.camel@Joe-Laptop> (raw)
In-Reply-To: <1310364039-17345-1-git-send-email-ravishankarkm32@gmail.com>
On Mon, 2011-07-11 at 11:30 +0530, Ravishankar wrote:
> This is a patch to the pcl818.c file that fixes up a brace warning found by the checkpatch.pl tool
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
[]
> @@ -1301,11 +1301,10 @@ static void setup_channel_list(struct comedi_device *dev,
> */
> static int check_single_ended(unsigned int port)
> {
> - if (inb(port + PCL818_STATUS) & 0x20) {
> + if (inb(port + PCL818_STATUS) & 0x20)
> return 1;
> - } else {
> + else
> return 0;
> - }
> }
I'd prefer this become:
static bool check_single_ended()
{
if (...)
return true;
return false;
}
next prev parent reply other threads:[~2011-07-11 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 3/3]Staging: comedi: fix brace coding style issue in pcl818.c>
2011-07-11 6:00 ` Ravishankar
2011-07-11 5:57 ` Joe Perches [this message]
2010-11-03 21:19 [PATCH 1/3] Staging: comedi: fix brace coding style issue in ni_tio.c This is a patch to the ni_tio.c file that fixes up a brace, indentation and overlines warning found by the checkpatch.pl tool Signed-off-by: Varayud Damian Alfredo <davarayud@gmail.com> Damian Varayud
2010-11-03 21:19 ` [PATCH 3/3] Staging: comedi: fix brace coding style issue in pcl818.c Damian Varayud
2010-11-03 22:32 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310363858.2446.15.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®