mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Kennedy <richard@rsk.demon.co.uk>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: reorder root_domain to remove 64 bit alignment padding
Date: Fri, 15 Jul 2011 12:23:14 +0100	[thread overview]
Message-ID: <1310728994.1977.15.camel@castor.rsk> (raw)
In-Reply-To: <1310726660.2586.313.camel@twins>

On Fri, 2011-07-15 at 12:44 +0200, Peter Zijlstra wrote:
> On Fri, 2011-07-15 at 11:41 +0100, Richard Kennedy wrote:
> > Reorder root_domain to remove 8 bytes of alignment padding on 64 bit
> > builds, this shrinks the size from 1736 to 1728 bytes, therefore using
> > one fewer cachelines.
> 
> depends a bit on how insane struct cpupri is, but yeah, good compaction.
> Thanks!

Thanks Peter,

argh -- I hadn't spotted that cpupri used NR_CPUS and was so variable in
size. I guess there won't be much benefit then, as the distros seem to
always set NR_CPUS to some insanely huge value ;)

regards
Richard 



  reply	other threads:[~2011-07-15 11:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15 10:41 Richard Kennedy
2011-07-15 10:44 ` Peter Zijlstra
2011-07-15 11:23   ` Richard Kennedy [this message]
2011-07-15 18:59     ` Henrique de Moraes Holschuh
2011-07-21 18:30 ` [tip:sched/core] sched: Reorder " tip-bot for Richard Kennedy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310728994.1977.15.camel@castor.rsk \
    --to=richard@rsk.demon.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®