From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521Ab1GOL2v (ORCPT ); Fri, 15 Jul 2011 07:28:51 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:53588 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775Ab1GOL2u (ORCPT ); Fri, 15 Jul 2011 07:28:50 -0400 X-Authority-Analysis: v=1.1 cv=PfPQ8rIoTcZsncbPZjVSZ7K0hy8Zc4hmL68r4VPNpKE= c=1 sm=0 a=VR3q0FbkgwYA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=hlDR-tgqZqmPK0ABcpQA:9 a=PUjeQqilurYA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: [PATCH -tip 00/13]tracing/kprobes: Dynamic events on module support From: Steven Rostedt To: Masami Hiramatsu Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Frederic Weisbecker , Peter Zijlstra , linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com In-Reply-To: <20110627072626.6528.41792.stgit@fedora15> References: <20110627072626.6528.41792.stgit@fedora15> Content-Type: text/plain; charset="ISO-8859-15" Date: Fri, 15 Jul 2011 07:28:48 -0400 Message-ID: <1310729328.27864.61.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-06-27 at 16:26 +0900, Masami Hiramatsu wrote: > Hi Steven, > > Here, I'd like to push updates of dynamic events and perf-probe > for supporting dynamic events on module. > > The main part of this series is 1-5th patches for kprobes and > dynamic event tracer, which allows us to add events on offline > kernel module. This means we can put events even on the init > functions of the drivers before loading. The requirement of > this feature comes from my recent experience of a driver > debugging. It had a timing bug in the initialization routine, > and it was hard to catch them without tracing the behavior. > > I added some perf-probe updates (which including some resent > patches), And it's OK to pull only the main part (kprobes and > ftrace patches) without perf updates. > OK I pulled in everything but patch 10, as that seemed to have an issue with the message that David Ahern brought up. I left that one out as it really wasn't necessary for the other patches. If you want to just resend that one patch with an update, I can pull that one in too. -- Steve > > Thank you, > > --- > > Masami Hiramatsu (13): > perf probe: Support adding probes on offline kernel modules > perf probe: Add probed module in front of function > [RESEND]perf probe: Introduce debuginfo to encapsulate dwarf information > [RESEND]perf probe: Warn when more than two lines are given > [RESEND][CLEANUP]perf-probe: Move dwarf library routines to dwarf-aux.{c,h} > [RESEND][CLEANUP]perf probe: Remove redundant dwarf functions > [RESEND][CLEANUP]perf probe: Move strtailcmp to string.c > [RESEND][CLEANUP]perf probe: Rename DIE_FIND_CB_FOUND to DIE_FIND_CB_END > tracing/kprobe: Update symbol reference when loading module > tracing/kprobes: Support module init function probing > kprobes: Return -ENOENT if probe point doesn't exist > [CLEANUP]tracing/kprobes: merge trace probe enable/disable functions > [CLEANUP]tracing/kprobes: Rename probe_* to trace_probe_* > > > Documentation/trace/kprobetrace.txt | 9 > kernel/kprobes.c | 33 + > kernel/trace/trace_kprobe.c | 314 +++++++++---- > tools/perf/Documentation/perf-probe.txt | 6 > tools/perf/Makefile | 2 > tools/perf/builtin-probe.c | 14 - > tools/perf/util/dwarf-aux.c | 663 +++++++++++++++++++++++++++ > tools/perf/util/dwarf-aux.h | 100 ++++ > tools/perf/util/probe-event.c | 165 +++++-- > tools/perf/util/probe-event.h | 1 > tools/perf/util/probe-finder.c | 752 ++++--------------------------- > tools/perf/util/probe-finder.h | 43 +- > tools/perf/util/string.c | 19 + > tools/perf/util/util.h | 1 > 14 files changed, 1304 insertions(+), 818 deletions(-) > create mode 100644 tools/perf/util/dwarf-aux.c > create mode 100644 tools/perf/util/dwarf-aux.h >