From: Lin Ming <ming.m.lin@intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 5/6] perf tool: Allow system-wide 'perf stat' without 'command'
Date: Fri, 15 Jul 2011 14:35:02 +0000 [thread overview]
Message-ID: <1310740503-15608-6-git-send-email-ming.m.lin@intel.com> (raw)
In-Reply-To: <1310740503-15608-1-git-send-email-ming.m.lin@intel.com>
There are package level counters, for example Intel uncore counters,
can't be limited to process. So we should allow 'perf stat' to run without 'command'.
$ sudo perf stat -a -C 0 -e uncore:cycle
^C
Performance counter stats for 'CPU 0':
56,547,314 uncore:cycle
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
tools/perf/builtin-stat.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 1d08c80..84546ff 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -958,7 +958,14 @@ static void print_stat(int argc, const char **argv)
if (!csv_output) {
fprintf(stderr, "\n");
fprintf(stderr, " Performance counter stats for ");
- if(target_pid == -1 && target_tid == -1) {
+ if (system_wide) {
+ fprintf(stderr, "\'CPU ");
+ for (i = 0; i < evsel_list->cpus->nr; i++) {
+ fprintf(stderr, "%d", evsel_list->cpus->map[i]);
+ if (i < evsel_list->cpus->nr - 1)
+ fprintf(stderr, ",");
+ }
+ } else if (target_pid == -1 && target_tid == -1) {
fprintf(stderr, "\'%s", argv[0]);
for (i = 1; i < argc; i++)
fprintf(stderr, " %s", argv[i]);
@@ -1166,7 +1173,7 @@ int cmd_stat(int argc, const char **argv, const char *prefix __used)
} else if (big_num_opt == 0) /* User passed --no-big-num */
big_num = false;
- if (!argc && target_pid == -1 && target_tid == -1)
+ if (!system_wide && !argc && target_pid == -1 && target_tid == -1)
usage_with_options(stat_usage, options);
if (run_count <= 0)
usage_with_options(stat_usage, options);
--
1.7.5.1
next prev parent reply other threads:[~2011-07-15 14:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 14:34 [PATCH v2 0/6] perf: Intel uncore pmu counting support Lin Ming
2011-07-15 14:34 ` [PATCH v2 1/6] perf: Add interface to add general events to sysfs Lin Ming
2011-07-18 13:34 ` Peter Zijlstra
2011-07-18 14:00 ` Lin Ming
2011-07-19 7:52 ` Lin Ming
2011-07-25 7:08 ` Lin Ming
2011-07-25 7:57 ` Peter Zijlstra
2011-07-25 8:32 ` Lin Ming
2011-07-25 8:11 ` Lin Ming
2011-07-25 8:32 ` Peter Zijlstra
2011-07-25 15:20 ` Greg KH
2011-07-26 1:06 ` Lin Ming
2011-07-26 4:42 ` Greg KH
2011-07-26 5:50 ` Lin Ming
2011-07-15 14:34 ` [PATCH v2 2/6] perf, x86: Add Intel Nehalem/Westmere uncore pmu Lin Ming
2011-07-15 14:48 ` Lin Ming
2011-07-18 14:20 ` Peter Zijlstra
2011-07-18 14:54 ` Lin Ming
2011-07-18 16:11 ` Peter Zijlstra
2011-07-15 14:35 ` [PATCH v2 3/6] perf, x86: Add Intel SandyBridge " Lin Ming
2011-07-15 14:35 ` [PATCH v2 4/6] perf: Remove perf_event_attr::type check Lin Ming
2011-07-15 14:35 ` Lin Ming [this message]
2011-07-15 14:35 ` [PATCH v2 6/6] perf tool: Parse general/raw events from sysfs Lin Ming
2011-08-06 20:10 ` Stephane Eranian
2011-08-06 23:38 ` Lin Ming
2011-08-07 23:47 ` Stephane Eranian
2011-08-08 1:08 ` Lin Ming
2011-08-08 5:54 ` Stephane Eranian
2011-08-08 8:48 ` Peter Zijlstra
2011-08-08 8:57 ` Lin Ming
2011-08-08 9:03 ` Peter Zijlstra
2011-08-11 22:38 ` Stephane Eranian
2011-08-15 19:18 ` Corey Ashford
2011-08-31 12:21 ` [PATCH v2 0/6] perf: Intel uncore pmu counting support Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310740503-15608-6-git-send-email-ming.m.lin@intel.com \
--to=ming.m.lin@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome