From: Joe Perches <joe@perches.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Ravishankar <ravishankarkm32@gmail.com>,
devel@driverdev.osuosl.org, gregkh@suse.de,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 30/30 v2] Staging: comedi: fix printk() issue in das16m1.c
Date: Mon, 18 Jul 2011 08:46:24 -0700 [thread overview]
Message-ID: <1311003984.2286.89.camel@Joe-Laptop> (raw)
In-Reply-To: <alpine.LNX.2.00.1107181139270.2483@swampdragon.chaosbits.net>
On Mon, 2011-07-18 at 11:43 +0200, Jesper Juhl wrote:
> On Mon, 18 Jul 2011, Ravishankar wrote:
> > - printk(" io 0x%lx-0x%lx 0x%lx-0x%lx",
> > + printk(KERN_INFO " requesing the I/O region from 0x%lx-0x%lx 0x%lx-0x%lx",
> Correct spelling is "requesting" and the "from" should either have a
> matching "to" or just be dropped IMHO.
> Personally I'd just make it:
> " requesting I/O region 0x%lx-0x%lx 0x%lx-0x%lx"
[]
> I think the original text was better.
KERN_INFO is the wrong level.
Just log the errors at KERN_ERR/pr_err and make the rest
pr_debug or delete them.
prev parent reply other threads:[~2011-07-18 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH]Staging: comedi: fix printk() issue in das16m1.c>
2011-07-18 9:44 ` Ravishankar
2011-07-18 9:43 ` Jesper Juhl
2011-07-18 15:46 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311003984.2286.89.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®