mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	target-devel <target-devel@vger.kernel.org>
Subject: Re: [PATCH 2/2] scsi: target: remove custom hex2bin() implementation
Date: Mon, 18 Jul 2011 22:11:21 -0700	[thread overview]
Message-ID: <1311052281.16756.22.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <db7c7ad036769bcc0cd737e0b74136a05e57fc85.1310977653.git.andriy.shevchenko@linux.intel.com>

On Mon, 2011-07-18 at 11:27 +0300, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
> ---
>  drivers/target/target_core_cdb.c        |   16 ++++------------
>  drivers/target/target_core_fabric_lib.c |   17 +++++++----------
>  drivers/target/target_core_transport.c  |   28 ----------------------------
>  include/target/target_core_transport.h  |    1 -
>  4 files changed, 11 insertions(+), 51 deletions(-)
> 

Good catch to use proper include/linux/kernel.org:hex2bin() usage
instead of the custom code.

Committed as e270af8 with some minor changes to drop DEV_T10_WWN() macro
usage in favor of direct dereference following v4.1 style.

Thanks!

--nab



  reply	other threads:[~2011-07-19  5:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18  8:27 [PATCH 1/2] scsi: target: fix typo Assoication -> Association Andy Shevchenko
2011-07-18  8:27 ` [PATCH 2/2] scsi: target: remove custom hex2bin() implementation Andy Shevchenko
2011-07-19  5:11   ` Nicholas A. Bellinger [this message]
2011-07-19  5:08 ` [PATCH 1/2] scsi: target: fix typo Assoication -> Association Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311052281.16756.22.camel@haakon2.linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®