mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <pavan_savoy@ti.com>
To: <greg@kroah.com>, <linux-kernel@vger.kernel.org>
Cc: pavan_savoy@sify.com, Pavan Savoy <pavan_savoy@ti.com>
Subject: [PATCH 1/4] drivers:misc: ti-st: avoid a misleading dbg msg
Date: Wed, 20 Jul 2011 09:30:17 -0500	[thread overview]
Message-ID: <1311172225-17678-2-git-send-email-pavan_savoy@ti.com> (raw)
In-Reply-To: <1311172225-17678-1-git-send-email-pavan_savoy@ti.com>

From: Pavan Savoy <pavan_savoy@ti.com>

Previously the private data of each protocol registered to use ST was
used to determine whether the protocol was registered to use shared
transport or otherwise.
However, now a flag is_registered is maintained to identify whether a
protocol intends to use ST.
Upon closing of the UART the error message relevant to this lack of
un-registration was misleading and this patch fixes that.

Change-Id: Ieddf828c5fa9ceabcbf9346ebdfde797916ac1f3
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
---
 drivers/misc/ti-st/st_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
index 54c91ff..c8e335d 100644
--- a/drivers/misc/ti-st/st_core.c
+++ b/drivers/misc/ti-st/st_core.c
@@ -717,7 +717,7 @@ static void st_tty_close(struct tty_struct *tty)
 	 */
 	spin_lock_irqsave(&st_gdata->lock, flags);
 	for (i = ST_BT; i < ST_MAX_CHANNELS; i++) {
-		if (st_gdata->list[i] != NULL)
+		if (st_gdata->is_registered[i] == true)
 			pr_err("%d not un-registered", i);
 		st_gdata->list[i] = NULL;
 	}
-- 
1.7.4.1


  reply	other threads:[~2011-07-20 14:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20 14:30 [PATCH 0/4] drivers:misc: ti-st: platform specifics pavan_savoy
2011-07-20 14:30 ` pavan_savoy [this message]
2011-07-20 14:30   ` [PATCH 2/4] drivers:misc:ti-st: platform hooks for chip states pavan_savoy
2011-07-20 14:30     ` [PATCH 3/4] drivers:misc: ti-st: reinit completion on ver read pavan_savoy
2011-07-20 14:30       ` [PATCH 4/4] drivers:misc: ti-st: fail-safe on wrong pkt type pavan_savoy
2011-07-20 14:30         ` [PATCH 0/4] drivers:misc: ti-st: platform specifics pavan_savoy
2011-07-20 14:30           ` [PATCH 1/4] drivers:misc: ti-st: avoid a misleading dbg msg pavan_savoy
2011-07-20 14:30             ` [PATCH 2/4] drivers:misc:ti-st: platform hooks for chip states pavan_savoy
2011-07-20 14:30               ` [PATCH 3/4] drivers:misc: ti-st: reinit completion on ver read pavan_savoy
2011-07-20 14:30                 ` [PATCH 4/4] drivers:misc: ti-st: fail-safe on wrong pkt type pavan_savoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311172225-17678-2-git-send-email-pavan_savoy@ti.com \
    --to=pavan_savoy@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavan_savoy@sify.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®