From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202Ab1GTObw (ORCPT ); Wed, 20 Jul 2011 10:31:52 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:43616 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763Ab1GTOab (ORCPT ); Wed, 20 Jul 2011 10:30:31 -0400 From: To: , CC: pavan_savoy@sify.com, Pavan Savoy Subject: [PATCH 1/4] drivers:misc: ti-st: avoid a misleading dbg msg Date: Wed, 20 Jul 2011 09:30:22 -0500 Message-ID: <1311172225-17678-7-git-send-email-pavan_savoy@ti.com> X-Mailer: git-send-email 1.5.6.3 In-Reply-To: <1311172225-17678-6-git-send-email-pavan_savoy@ti.com> References: <1311172225-17678-1-git-send-email-pavan_savoy@ti.com> <1311172225-17678-2-git-send-email-pavan_savoy@ti.com> <1311172225-17678-3-git-send-email-pavan_savoy@ti.com> <1311172225-17678-4-git-send-email-pavan_savoy@ti.com> <1311172225-17678-5-git-send-email-pavan_savoy@ti.com> <1311172225-17678-6-git-send-email-pavan_savoy@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavan Savoy Previously the private data of each protocol registered to use ST was used to determine whether the protocol was registered to use shared transport or otherwise. However, now a flag is_registered is maintained to identify whether a protocol intends to use ST. Upon closing of the UART the error message relevant to this lack of un-registration was misleading and this patch fixes that. Change-Id: Ieddf828c5fa9ceabcbf9346ebdfde797916ac1f3 Signed-off-by: Pavan Savoy --- drivers/misc/ti-st/st_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index 54c91ff..c8e335d 100644 --- a/drivers/misc/ti-st/st_core.c +++ b/drivers/misc/ti-st/st_core.c @@ -717,7 +717,7 @@ static void st_tty_close(struct tty_struct *tty) */ spin_lock_irqsave(&st_gdata->lock, flags); for (i = ST_BT; i < ST_MAX_CHANNELS; i++) { - if (st_gdata->list[i] != NULL) + if (st_gdata->is_registered[i] == true) pr_err("%d not un-registered", i); st_gdata->list[i] = NULL; } -- 1.7.4.1