From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753198Ab1GZHxu (ORCPT ); Tue, 26 Jul 2011 03:53:50 -0400 Received: from mail.perches.com ([173.55.12.10]:4285 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752861Ab1GZHxn (ORCPT ); Tue, 26 Jul 2011 03:53:43 -0400 Subject: Re: [PATCH 1/2] kernel.h: Add DIV_ROUND_UP_ULL usage From: Joe Perches To: "Nicholas A. Bellinger" Cc: target-devel , linux-scsi , linux-kernel , Christoph Hellwig , Andy Grover , Hannes Reinecke , Roland Dreier , James Bottomley , Andrew Morton , Linus Torvalds In-Reply-To: <1311664225-20172-1-git-send-email-nab@linux-iscsi.org> References: <1311664225-20172-1-git-send-email-nab@linux-iscsi.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 26 Jul 2011 00:53:41 -0700 Message-ID: <1311666821.26957.13.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-07-26 at 07:10 +0000, Nicholas A. Bellinger wrote: > Add new DIV_ROUND_UP_ULL macro usage for 32-bit architectures requiring > unsigned long long division of sectors * dev_max_sectors. [] > diff --git a/include/linux/kernel.h b/include/linux/kernel.h [] > +#define DIV_ROUND_UP_ULL(ll,d) \ > + ({ unsigned long long _tmp = (ll)+(d)-1; do_div(_tmp, d); _tmp; }) Maybe use uint64_t and a temporary for d? #define DIV_ROUND_UP_ULL(ll, d) \ ({ \ typeof(d) _d = d; \ uint64_t _tmp = (uint64_t)(ll) + _d - 1; \ do_div(_tmp, _d); \ _tmp; \ })