From: Steven Rostedt <rostedt@goodmis.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Minchan Kim <minchan.kim@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH] cgroup/kmemcheck: No need to annotate base anymore
Date: Tue, 26 Jul 2011 13:44:04 -0400 [thread overview]
Message-ID: <1311702244.3526.100.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1311702110.3526.98.camel@gandalf.stny.rr.com>
On Tue, 2011-07-26 at 13:41 -0400, Steven Rostedt wrote:
> > We can still fall back to vmalloc allocation (even though it is really
> > not probable that alloc_pages_exact_nid would fail that early).
> > Is vmalloc a problem here? (sorry I am not familiar with kmemleak
> > internals) The original code didn't distinguish kmalloc vs. vmalloc.
> >
>
> Good question. I forgot to add the maintainer of kmemleak to the Cc
> list. (fixed here).
Depending on the answer, I suspect that the result will be to keep the
not_leak call, and just add a call directly to kmemleak_alloc() in the
page_alloc() side.
I'll have a patch ready on hand when we find out :)
-- Steve
next prev parent reply other threads:[~2011-07-26 17:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 17:05 Steven Rostedt
2011-07-26 17:38 ` Michal Hocko
2011-07-26 17:41 ` Steven Rostedt
2011-07-26 17:44 ` Steven Rostedt [this message]
2011-07-26 18:17 ` [PATCH v2] cgroup/kmemcheck: Annotate alloc_page() for cgroup allocations Steven Rostedt
2011-07-26 18:43 ` Michal Hocko
2011-07-26 19:04 ` Steven Rostedt
2011-07-26 19:19 ` [PATCH v3] " Steven Rostedt
2011-07-26 22:13 ` Johannes Weiner
2011-07-26 23:03 ` Minchan Kim
2011-07-27 0:55 ` KAMEZAWA Hiroyuki
2011-08-12 9:58 ` Catalin Marinas
2011-07-27 2:10 ` [PATCH v3 RESEND] " Steven Rostedt
2011-07-29 13:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311702244.3526.100.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=minchan.kim@gmail.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®