mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Christoph Hellwig <hch@infradead.org>,
	Bryan Schumaker <bjschuma@netapp.com>
Cc: Justin Piszcz <jpiszcz@lucidpixels.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: 2.6.xx: NFS: directory motion/cam2 contains a readdir loop
Date: Wed, 27 Jul 2011 16:37:01 -0400	[thread overview]
Message-ID: <1311799021.25645.41.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20110727194722.GA9345@infradead.org>

On Wed, 2011-07-27 at 15:47 -0400, Christoph Hellwig wrote: 
> On Wed, Jul 27, 2011 at 03:44:20PM -0400, Justin Piszcz wrote:
> > 
> > 
> > On Wed, 27 Jul 2011, Christoph Hellwig wrote:
> > 
> > >On Wed, Jul 27, 2011 at 03:35:01PM -0400, Justin Piszcz wrote:
> > >>Currently I do not see any dupes, however I have a script that moves
> > >>images out of the directory once an hour:
> > >>0 * * * * /usr/local/bin/move_to_old2.sh > /dev/null 2>&1
> > >
> > >Do you keep adding files to the directory while you move files out?
> > Yes, otherwise there are too many files in the directory and viewers, e.g.,
> > each geeqie (picture viewer) will use > 4-6GB of memory, so I try to keep
> > it around 5,000 pictures or less.
> > 
> > >What's the rate of additions/removals to the directory?
> > Additions it depends, around 5,000 over a 12hr period, 416/hr, current:
> > 
> > atom:/d1/motion# find cam1|wc
> >    5215    5215  166853
> > atom:/d1/motion# find cam2|wc
> >    5069    5069  162181
> > atom:/d1/motion# find cam3|wc
> >    5594    5594  178981
> > atom:/d1/motion#
> 
> This sounds a lot like xfs simply filling up the directory index slots
> of files that you just moved out with new files, and nfs falsely
> claiming that this is a problem.

Yep. There is an existing bugzilla report for this bug at

   https://bugzilla.kernel.org/show_bug.cgi?id=38572

I have a preliminary patch there that attempts to turn off the loop
detection when the directory is seen to change, however that patch still
appears to have a bug in it, and I haven't had time to figure out what
is wrong yet.

Can you perhaps take a look, Bryan?

Cheers
  Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


  parent reply	other threads:[~2011-07-27 20:37 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-27 13:54 Justin Piszcz
2011-07-27 16:07 ` J. Bruce Fields
2011-07-27 16:28   ` Justin Piszcz
2011-07-27 16:40     ` Bryan Schumaker
2011-07-27 17:00       ` Ruediger Meier
2011-07-27 17:09         ` Bryan Schumaker
2011-07-27 17:17         ` Justin Piszcz
2011-07-27 17:45           ` J. Bruce Fields
2011-07-27 18:28         ` Bryan Schumaker
2011-07-27 17:15       ` Justin Piszcz
2011-07-27 18:11     ` Christoph Hellwig
2011-07-27 19:35       ` Justin Piszcz
2011-07-27 19:39         ` Christoph Hellwig
2011-07-27 19:44           ` Justin Piszcz
2011-07-27 19:47             ` Christoph Hellwig
2011-07-27 19:54               ` Bryan Schumaker
2011-07-27 20:02                 ` Christoph Hellwig
2011-07-27 20:05                   ` Christoph Hellwig
2011-07-27 20:26                   ` Rüdiger Meier
2011-07-27 20:47                     ` Christoph Hellwig
2011-07-27 21:21                       ` Rüdiger Meier
2011-07-27 19:57               ` Justin Piszcz
2011-07-27 20:37               ` Trond Myklebust [this message]
2011-07-27 20:54                 ` Trond Myklebust
2011-07-27 20:56                   ` Trond Myklebust
2011-07-27 21:24                     ` Justin Piszcz
2011-07-27 22:44                       ` Justin Piszcz
2011-07-28 20:48                         ` Trond Myklebust
2011-07-29 20:52                           ` Bryan Schumaker
2011-07-29 20:59                             ` Justin Piszcz
2011-07-29 22:03                               ` Trond Myklebust
2011-07-29 22:23                                 ` Justin Piszcz
2011-07-30  9:58                                   ` Justin Piszcz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311799021.25645.41.camel@lade.trondhjem.org \
    --to=trond.myklebust@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=bjschuma@netapp.com \
    --cc=hch@infradead.org \
    --cc=jpiszcz@lucidpixels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®