From: Joe Perches <joe@perches.com>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: broken checkpatch signature checking
Date: Wed, 27 Jul 2011 21:41:42 -0700 [thread overview]
Message-ID: <1311828102.10042.1.camel@Joe-Laptop> (raw)
In-Reply-To: <20110728043327.GA21448@redhat.com>
On Thu, 2011-07-28 at 00:33 -0400, Dave Jones wrote:
> The signature checking patches in commit 2011247550 have broken one use-case for me.
> I pipe the git-commits mailing list to it and skim the summary once a day[*]
> Because git indents its changelogs, every single commit is now warning
> with this..
> WARNING: Do not use whitespace before Signed-off-by:
> #5252:
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Dave
> [*] It's too noisy to do anything useful with right now, which is
> why I'd like to filter out all the whitespace crap, but hopefully
> that'll happen eventually.
Hey Dave.
Maybe you could use --ignore=BAD_SIGN_OFF for this reviewing?
I think that the general use case is OK.
I'm not sure that it's appropriate to use
checkpatch on git log output.
cheers, Joe
next prev parent reply other threads:[~2011-07-28 4:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 4:33 Dave Jones
2011-07-28 4:41 ` Joe Perches [this message]
2011-07-28 4:49 ` Dave Jones
2011-07-28 4:59 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311828102.10042.1.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®