From: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
To: jbarnes@virtuousgeek.org, torvalds@linux-foundation.org
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, eyal@mips.com, zenon@mips.com,
dengcheng.zhu@gmail.com
Subject: [PATCH 1/2] PCI: make pci_claim_resource() work with conflict resources as appropriate
Date: Thu, 28 Jul 2011 19:28:31 +0800 [thread overview]
Message-ID: <1311852512-7340-2-git-send-email-dengcheng.zhu@gmail.com> (raw)
In-Reply-To: <1311852512-7340-1-git-send-email-dengcheng.zhu@gmail.com>
In resolving a network driver issue with the MIPS Malta platform, the root
cause was traced into pci_claim_resource():
MIPS System Controller's PCI I/O resources stay in 0x1000-0xffffff. When
PCI quirks start claiming resources using request_resource_conflict(),
collisions happen and -EBUSY is returned, thereby rendering the onboard AMD
PCnet32 NIC unaware of quirks' region and preventing the NIC from functioning.
For PCI quirks, PIIX4 ACPI is expected to claim 0x1000-0x103f, and PIIX4 SMB to
claim 0x1100-0x110f, both of which fall into the MSC I/O range. Certainly, we
can increase the start point of this range in arch/mips/mti-malta/malta-pci.c to
avoid the collisions. But a fix in here looks more justified, though it seems to
have a wider impact. Using insert_xxx as opposed to request_xxx will register
PCI quirks' resources as children of MSC I/O and return OK, instead of seeing
collisions which are actually resolvable.
Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
---
drivers/pci/setup-res.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index bc0e6ee..40d767e 100644
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -102,7 +102,7 @@ int pci_claim_resource(struct pci_dev *dev, int resource)
return -EINVAL;
}
- conflict = request_resource_conflict(root, res);
+ conflict = insert_resource_conflict(root, res);
if (conflict) {
dev_info(&dev->dev,
"address space collision: %pR conflicts with %s %pR\n",
--
1.7.1
next prev parent reply other threads:[~2011-07-28 11:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 11:28 [PATCH 0/2] PCI driver to use insert_resource_conflict() to claim resources Deng-Cheng Zhu
2011-07-28 11:28 ` Deng-Cheng Zhu [this message]
2011-07-28 11:53 ` [PATCH 1/2] PCI: make pci_claim_resource() work with conflict resources as appropriate Ralf Baechle
2011-07-29 6:32 ` Deng-Cheng Zhu
2011-07-29 17:35 ` Bjorn Helgaas
2011-08-01 10:13 ` Deng-Cheng Zhu
2011-08-01 15:21 ` Bjorn Helgaas
2011-07-28 15:59 ` Bjorn Helgaas
2011-07-29 6:35 ` Deng-Cheng Zhu
2011-07-28 11:28 ` [PATCH 2/2] kernel/resource: enrich the comment for insert_resource_conflict() Deng-Cheng Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311852512-7340-2-git-send-email-dengcheng.zhu@gmail.com \
--to=dengcheng.zhu@gmail.com \
--cc=eyal@mips.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zenon@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®