From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756397Ab1G2MwV (ORCPT ); Fri, 29 Jul 2011 08:52:21 -0400 Received: from mga11.intel.com ([192.55.52.93]:47244 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756314Ab1G2MwU (ORCPT ); Fri, 29 Jul 2011 08:52:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,287,1309762800"; d="scan'208";a="35909028" Subject: Re: [PATCH 04/18] dmaengine/amba-pl08x: Remove redundant comment and rewrite original From: "Koul, Vinod" To: Viresh Kumar Cc: linus.walleij@linaro.org, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, armando.visconti@st.com, shiraz.hashim@st.com, vipin.kumar@st.com, rajeev-dlh.kumar@st.com, deepak.sikri@st.com, vipulkumar.samar@st.com, amit.virdi@st.com, pratyush.anand@st.com, bhupesh.sharma@st.com, viresh.linux@gmail.com In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Fri, 29 Jul 2011 17:39:15 +0530 Message-ID: <1311941355.1536.529.camel@vkoul-udesk3> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2011-07-29 at 16:19 +0530, Viresh Kumar wrote: > Similar comment is present over routine also pl08x_choose_master_bus(). Keeping > one of them. Also rewrite that comment to convey message clearly. > > Signed-off-by: Viresh Kumar > --- > drivers/dma/amba-pl08x.c | 11 +++-------- > 1 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c > index 1f7c510..4a64fdf 100644 > --- a/drivers/dma/amba-pl08x.c > +++ b/drivers/dma/amba-pl08x.c > @@ -498,9 +498,9 @@ struct pl08x_lli_build_data { > }; > > /* > - * Autoselect a master bus to use for the transfer this prefers the > - * destination bus if both available if fixed address on one bus the > - * other will be chosen > + * Autoselect a master bus to use for the transfer > + * - prefers the destination bus if both available > + * - if fixed address on one bus the other will be chosen Not sure I get it, English is not my first language :) > */ > static void pl08x_choose_master_bus(struct pl08x_lli_build_data *bd, > struct pl08x_bus_data **mbus, struct pl08x_bus_data **sbus, u32 cctl) > @@ -626,11 +626,6 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x, > /* We need to count this down to zero */ > bd.remainder = txd->len; > > - /* > - * Choose bus to align to > - * - prefers destination bus if both available > - * - if fixed address on one bus chooses other > - */ > pl08x_choose_master_bus(&bd, &mbus, &sbus, cctl); > > dev_vdbg(&pl08x->adev->dev, "src=0x%08x%s/%u dst=0x%08x%s/%u len=%zu " -- ~Vinod