From: Frederic Weisbecker <fweisbec@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Aditya Kali <adityakali@google.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: [PATCH 8/8] res_counter: Allow charge failure pointer to be null
Date: Fri, 29 Jul 2011 18:13:30 +0200 [thread overview]
Message-ID: <1311956010-32076-9-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1311956010-32076-1-git-send-email-fweisbec@gmail.com>
So that callers of res_counter_charge() don't have to create and
pass this pointer even if they aren't interested in it.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Paul Menage <menage@google.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Aditya Kali <adityakali@google.com>
Cc: Oleg Nesterov <oleg@redhat.com>
---
kernel/cgroup_task_counter.c | 6 ++----
kernel/res_counter.c | 6 ++++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/cgroup_task_counter.c b/kernel/cgroup_task_counter.c
index 7f12ac9..dacc4a9 100644
--- a/kernel/cgroup_task_counter.c
+++ b/kernel/cgroup_task_counter.c
@@ -93,11 +93,10 @@ static int task_counter_can_attach_task(struct cgroup *cgrp, struct cgroup *old_
{
struct res_counter *res = cgroup_task_counter_res(cgrp);
struct res_counter *old_res = cgroup_task_counter_res(old_cgrp);
- struct res_counter *limit_fail_at;
common_ancestor = res_counter_common_ancestor(res, old_res);
- return res_counter_charge_until(res, common_ancestor, 1, &limit_fail_at);
+ return res_counter_charge_until(res, common_ancestor, 1, NULL);
}
static void task_counter_cancel_attach_task(struct cgroup *cgrp, struct task_struct *tsk)
@@ -154,13 +153,12 @@ int cgroup_task_counter_fork(struct task_struct *child)
{
struct cgroup_subsys_state *css = child->cgroups->subsys[tasks_subsys_id];
struct cgroup *cgrp = css->cgroup;
- struct res_counter *limit_fail_at;
/* Optimize for the root cgroup case, which doesn't have a limit */
if (!cgrp->parent)
return 0;
- return res_counter_charge(cgroup_task_counter_res(cgrp), 1, &limit_fail_at);
+ return res_counter_charge(cgroup_task_counter_res(cgrp), 1, NULL);
}
struct cgroup_subsys tasks_subsys = {
diff --git a/kernel/res_counter.c b/kernel/res_counter.c
index 725dfa6..7eac803 100644
--- a/kernel/res_counter.c
+++ b/kernel/res_counter.c
@@ -43,14 +43,16 @@ int res_counter_charge_until(struct res_counter *counter,
unsigned long flags;
struct res_counter *c, *u;
- *limit_fail_at = NULL;
+ if (limit_fail_at)
+ *limit_fail_at = NULL;
local_irq_save(flags);
for (c = counter; c != limit; c = c->parent) {
spin_lock(&c->lock);
ret = res_counter_charge_locked(c, val);
spin_unlock(&c->lock);
if (ret < 0) {
- *limit_fail_at = c;
+ if (limit_fail_at)
+ *limit_fail_at = c;
goto undo;
}
}
--
1.7.5.4
next prev parent reply other threads:[~2011-07-29 16:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 16:13 [PATCH 0/8 v3] cgroups: Task counter subsystem (was: New max number of tasks subsystem) Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 1/8] cgroups: Add res_counter_write_u64() API Frederic Weisbecker
2011-08-09 15:17 ` Oleg Nesterov
2011-08-09 17:31 ` Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 2/8] cgroups: New resource counter inheritance API Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 3/8] cgroups: Add previous cgroup in can_attach_task/attach_task callbacks Frederic Weisbecker
2011-08-17 2:40 ` Li Zefan
2011-08-27 13:58 ` Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 4/8] cgroups: New cancel_attach_task subsystem callback Frederic Weisbecker
2011-08-17 2:40 ` Li Zefan
2011-08-27 13:58 ` Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 5/8] cgroups: Ability to stop res charge propagation on bounded ancestor Frederic Weisbecker
2011-08-17 2:41 ` Li Zefan
2011-08-27 13:59 ` Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 6/8] cgroups: Add res counter common ancestor searching Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 7/8] cgroups: Add a task counter subsystem Frederic Weisbecker
2011-08-01 23:13 ` Andrew Morton
2011-08-04 14:05 ` Frederic Weisbecker
2011-08-09 15:11 ` Oleg Nesterov
2011-08-09 17:27 ` Frederic Weisbecker
2011-08-09 17:57 ` Oleg Nesterov
2011-08-09 18:09 ` Frederic Weisbecker
2011-08-09 18:19 ` Oleg Nesterov
2011-08-09 18:34 ` Frederic Weisbecker
2011-08-09 18:39 ` Oleg Nesterov
2011-08-17 3:18 ` Li Zefan
2011-08-27 14:16 ` Frederic Weisbecker
2011-07-29 16:13 ` Frederic Weisbecker [this message]
2011-08-17 2:44 ` [PATCH 8/8] res_counter: Allow charge failure pointer to be null Li Zefan
2011-08-27 14:05 ` Frederic Weisbecker
2011-08-01 23:19 ` [PATCH 0/8 v3] cgroups: Task counter subsystem (was: New max number of tasks subsystem) Andrew Morton
2011-08-03 14:29 ` Frederic Weisbecker
2011-08-12 21:11 ` Tim Hockin
2011-08-16 16:01 ` Kay Sievers
2011-08-18 14:33 ` [RFD] Task counter: cgroup core feature or cgroup subsystem? (was Re: [PATCH 0/8 v3] cgroups: Task counter subsystem) Frederic Weisbecker
2011-08-23 16:07 ` Paul Menage
2011-08-24 17:54 ` Frederic Weisbecker
2011-08-26 7:28 ` Li Zefan
2011-08-26 14:58 ` Paul Menage
2011-09-06 9:06 ` Li Zefan
2011-08-26 15:16 ` Paul Menage
2011-08-27 13:40 ` Frederic Weisbecker
2011-08-31 22:36 ` Paul Menage
2011-08-31 21:54 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311956010-32076-9-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=adityakali@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome