From: David Woodhouse <dwmw2@infradead.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Song, Youquan" <youquan.song@intel.com>,
"Mallick, Asit K" <asit.k.mallick@intel.com>,
Prarit Bhargava <prarit@redhat.com>,
trenn@suse.de
Subject: Re: [patch] x86, x2apic: enable the bios request for x2apic optout
Date: Sun, 31 Jul 2011 00:09:45 +0100 [thread overview]
Message-ID: <1312067391.22074.58.camel@i7.infradead.org> (raw)
In-Reply-To: <1311987173.12777.7.camel@sbsiddha-mobl2>
On Fri, 2011-07-29 at 17:52 -0700, Suresh Siddha wrote:
>
> + WARN(!eim, KERN_WARNING "Your BIOS is broken and requested that"
> + " x2apic be disabled\n This will leave your machine"
> + " vulnerable to irq-injection attacks\n Use"
> + " 'intremap=no_x2apic_optout' to override BIOS "
> + "request\n");
Please don't break strings, except at the \n. I think checkpatch.pl even
has an exception to its 80-column rule for this, these days?
If I see this message and search in the kernel source for the string
'requested that x2apic be disabled', I should be able to find it.
--
dwmw2
next prev parent reply other threads:[~2011-07-30 23:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 0:52 Suresh Siddha
2011-07-30 23:09 ` David Woodhouse [this message]
2011-08-01 3:01 ` Suresh Siddha
2011-08-06 7:00 ` Ingo Molnar
2011-08-08 17:48 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312067391.22074.58.camel@i7.infradead.org \
--to=dwmw2@infradead.org \
--cc=asit.k.mallick@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prarit@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=trenn@suse.de \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®