From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145Ab1HAVQJ (ORCPT ); Mon, 1 Aug 2011 17:16:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24670 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752958Ab1HAVQD (ORCPT ); Mon, 1 Aug 2011 17:16:03 -0400 Subject: Re: [PATCH] libertas: prioritize usb8388_v5.bin firmware on OLPC machines From: Dan Williams To: Andres Salomon Cc: libertas-dev@lists.infradead.org, cjb@laptop.org, David Woodhouse , Daniel Drake , linux-kernel@vger.kernel.org Date: Mon, 01 Aug 2011 16:20:07 -0500 In-Reply-To: <20110801112522.1ba02f5e@debxo> References: <20110731000300.5c08e95f@debxo> <20110731000521.45e48638@debxo> <1312219075.6121.20.camel@dcbw.foobar.com> <20110801112522.1ba02f5e@debxo> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Message-ID: <1312233609.3299.24.camel@dcbw.foobar.com> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-08-01 at 11:25 -0700, Andres Salomon wrote: > On Mon, 01 Aug 2011 12:17:23 -0500 > Dan Williams wrote: > > > On Sun, 2011-07-31 at 13:59 +0100, Daniel Drake wrote: > > > On 31 July 2011 08:05, Andres Salomon wrote: > > > > Note: I've not tested this out yet on an XO-1. I'll do that > > > > after some feedback regarding the matching linux-firmware pull > > > > request. This should address dsd's concern about changing the > > > > loading order of the firmware. > > > > > > That indeed was a concern, but only until Dan Williams and Chris > > > pointed out that OLPC is the only usb8388 user. With that in mind, I > > > am in agreement with them that simply putting usb8388_olpc_v5.bin > > > (or whatever name is chosen) at the top of the firmware loading > > > list is the best option. > > > > Yeah, patches for that would be immediately acked. > > > > What's your opinion on overwriting usb8388_v5.bin with OLPC's version, > versus having both a usb8388_v5.bin and a usb8388_olpc_v5.bin? I'd slightly prefer to keep them separate, but I don't really care that much. Whatever you'd like to do here is fine. Dan