From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753279Ab1HBKfT (ORCPT ); Tue, 2 Aug 2011 06:35:19 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:59056 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107Ab1HBKfL (ORCPT ); Tue, 2 Aug 2011 06:35:11 -0400 From: Julia Lawall To: Andrew Morton , trivial@kernel.org Cc: kernel-janitors@vger.kernel.org, Stefani Seibold , Andrea Righi , "Ira W. Snyder" , linux-kernel@vger.kernel.org Subject: [PATCH 1/11] kernel/kfifo.c: trivial: use BUG_ON Date: Tue, 2 Aug 2011 12:34:54 +0200 Message-Id: <1312281304-11847-2-git-send-email-julia@diku.dk> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1312281304-11847-1-git-send-email-julia@diku.dk> References: <1312281304-11847-1-git-send-email-julia@diku.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Use BUG_ON(x) rather than if(x) BUG(); The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; @@ -if (x) BUG(); +BUG_ON(x); @@ identifier x; @@ -if (!x) BUG(); +BUG_ON(!x); // Signed-off-by: Julia Lawall --- kernel/kfifo.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff -u -p a/kernel/kfifo.c b/kernel/kfifo.c --- a/kernel/kfifo.c +++ b/kernel/kfifo.c @@ -562,8 +562,7 @@ EXPORT_SYMBOL(__kfifo_to_user_r); unsigned int __kfifo_dma_in_prepare_r(struct __kfifo *fifo, struct scatterlist *sgl, int nents, unsigned int len, size_t recsize) { - if (!nents) - BUG(); + BUG_ON(!nents); len = __kfifo_max_r(len, recsize); @@ -586,8 +585,7 @@ EXPORT_SYMBOL(__kfifo_dma_in_finish_r); unsigned int __kfifo_dma_out_prepare_r(struct __kfifo *fifo, struct scatterlist *sgl, int nents, unsigned int len, size_t recsize) { - if (!nents) - BUG(); + BUG_ON(!nents); len = __kfifo_max_r(len, recsize);